Bump Khepri to 0.17.1 #12753
Merged
Bump Khepri to 0.17.1 #12753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
3 times, most recently
from
6d289fe to
cc6185d
Compare
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
6 times, most recently
from
5cb0a79 to
42f571a
Compare
dumbbell
reviewed
Dec 16, 2024
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
3 times, most recently
from
17e7652 to
d4c49f2
Compare
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
3 times, most recently
from
8caf8c0 to
8efd8ca
Compare
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
from
8efd8ca to
3b09f4c
Compare
|
Thank you for updating the branch! I’m working on updating Ra in Khepri but there are small changes of behaviors that cause test flakes. I fixed one of them (Ra can reture |
|
I fixed the bug in Do you think we can update Khepri in RabbitMQ now? Perhaps we should focus on that and release Khepri 0.17.0 this week. |
the-mikedavis
force-pushed
the
md/khepri-0-17
branch
2 times, most recently
from
1b8eec3 to
f2f37d7
Compare
dumbbell
reviewed
Feb 3, 2025
dumbbell
reviewed
Feb 3, 2025
|
The upgrade to RA 2.16 in the broker seems to cause a flake (#13172) when the stream plugin uses a consistent read to check if some nodes are in maintenance node. Feel free to ping me when you think this PR is ready, I can run the stream plugin test suite against it to make sure the flake is gone. |
|
I submitted #13217 to remove |
dumbbell
force-pushed
the
md/khepri-0-17
branch
3 times, most recently
from
7d4a03f to
f3e2c31
Compare
dumbbell
force-pushed
the
md/khepri-0-17
branch
5 times, most recently
from
bea243e to
24eccc7
Compare
dumbbell
force-pushed
the
md/khepri-0-17
branch
6 times, most recently
from
cdf5bec to
6e6863a
Compare
... and khepri_mnesia_migration from 0.7.2 to 0.8.0. Khepri release notes: * https://github.com/rabbitmq/khepri/releases/tag/v0.17.0 * https://github.com/rabbitmq/khepri/releases/tag/v0.17.1 khepri_mnesia_migration release notes: https://github.com/rabbitmq/khepri_mnesia_migration/releases/tag/v0.8.0
[Why] In Khepri 0.17.0, `khepri_cluster:locally_known_members/1` and `khepri_cluster:locally_known_node/1` were replaced with `khepri_cluster:members/2` and `khepri_cluster:nodes/2` with `favor` set to `low_latency` - this matches the interface for queries in Khepri.
[Why] All callers of `khepri_adv` and `khepri_tx_adv` need updates to handle the now uniform return type of `khepri:node_props_map()` in Khepri 0.17.0. [How] We don't need any compatibility code to handle "either the old return type or the new return type" from the khepri_adv API because the translation is done entirely in the "client side" code in Khepri - meaning that the return value from the Ra server is the same but it is translated differently by the functions in `khepri_adv`. However, we need to adapt transaction functions because they may be executed on different versions of Khepri and the behaviour of `khepri_tx_adv` can be different. To take the possible change of return value format, we use the new `khepri_tx:does_api_comply_with/1` to know what to expect.
…i_db` enable function [Why] The feature flag enable function is called during the initial migration or when a node is later added to a cluster. In this latter situation, the cluster is already formed and the Mnesia tables were already migrated. Syncing the cluster in this specific situation might kick another node that is currently unreachable. [How] If the node running the enable function is already clustered, we skip the cluster sync.
…rella [Why] This makes sure that nodes are clustered the same way, whether the tests are executed with or without a secondary umbrella.
This is to make sure the old node uses the latest khepri_mnesia_migration patch release.
github-project-automation
bot
moved this from In Progress
to Done
in Khepri as the default metadata store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Khepri from 0.16.0 to 0.17.1 and khepri_mnesia_migration from 0.7.2 to 0.8.0.
Khepri release notes:
khepri_mnesia_migration release notes:
https://github.com/rabbitmq/khepri_mnesia_migration/releases/tag/v0.8.0
This pull request handles the breaking changes in Khepri 0.17.0.
It also uses a snapshot of an unreleased version of RabbitMQ 4.0.x to benefit from the improvement in khepri_mnesia_migration 0.7.2. This is only to reduce the chance of flaky tests in CI, it is not required to upgrade from 4.0.x to 4.2.0+.