Consistent logging #14232
Draft
Consistent logging #14232
+1,803
−2,415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuratczyk
force-pushed
the
consistent-logging
branch
6 times, most recently
from
b77fb53 to
7e3ad60
Compare
mkuratczyk
force-pushed
the
consistent-logging
branch
2 times, most recently
from
b3a2cc5 to
e2b7ed3
Compare
It's added automatically by logger
`?RMQLOG_DOMAIN_GLOBAL` used to be added by a now deleted logging module rabbit_log.
mkuratczyk
force-pushed
the
consistent-logging
branch
from
e2b7ed3 to
4f3f4b0
Compare
mkuratczyk
force-pushed
the
consistent-logging
branch
2 times, most recently
from
5b43b42 to
02df90c
Compare
mkuratczyk
force-pushed
the
consistent-logging
branch
from
02df90c to
108a39f
Compare
Some community plugins use rabbit_log. To simplify the transition, we can keep this module as a simple wrapper on logger macros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make our logging more consistent:
pid => self()metadata, since that's automatically added by loggerThe domain should be set on more processes, but we can do that over time. The fact they are missing shouldn't affect anything anyway, since currently we don't log the domain on the logger level, but rather many log strings contain the domain "informally" (eg. peer discovery sets the domain but also prefixes all logs with "Peer discovery:")