CI: Enable Erlang problem matchers #14703
Merged
+57
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
commented
Oct 16, 2025
In order to get the right subdirectory for GH to find our files we use `sed` to modify paths in the output. We use `pipefail` to make sure failures are propagated. We use `NON_DETERMINISTIC` to make sure our paths are full and not just the file.erl. We disable styling in non-parallel CT runs. This is needed in order to pick up errors. Currently these errors will not be annotated directly in PRs, a pending OTP PR will improve that. Parallel CT runs write GH annotations directly.
There's one test that kills the queue on purpose.
UTF-8 validation that used xmerl_ucs:from_bin/1 now uses unicode:characters_to_binary/3.
Identical clause was found in the same function.
lhoguin
force-pushed
the
loic-problem-matchers
branch
from
7e93397 to
a1960c8
Compare
Changing the path to a non-existent /ws2 still succeeded. Other tests properly check connecting.
lhoguin
force-pushed
the
loic-problem-matchers
branch
2 times, most recently
from
e7fa9a8 to
f05b18d
Compare
lhoguin
changed the title
lhoguin
changed the title
michaelklishin
approved these changes
Oct 23, 2025
|
@lhoguin this kind of annotations on PRs certainly looks promising :) I assume we want to see how it goes for |
|
Yeah and have 4.2 release first. We may also not want the xmerl commit in 4.2 and below as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit enables problem matchers. Subsequent commits are varied fixes found after enabling problem matchers.