In header opt, ensure name case doesn't matter #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did a review of the code and can confirm that header names are taken into account without regard to case when optimizing header checks. Although existing test cases cover this case, added a few additional tests which check this under different header step types... |
|
This closes #319 |
RackerWilliams
force-pushed
the
header_name_check
branch
from
63fa80a to
ba862d3
Compare
|
Rebased to resolve conflicts with release notes. |
RackerWilliams
force-pushed
the
header_name_check
branch
from
ba862d3 to
469af06
Compare
|
Rebasing again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking into optimizing header checks, we don't take into account that the case of the name of the headers doesn't matter. We may be missing opportunities to optimize if the name of the header is specified using different case in different parts of the WADL.