Resolving the remote datastore health check service issue #2006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make it so that if the remote datastore service is removed from the services in the system model, its health check issues will also be removed. Without this change, Repose would continue returning 503s because of the reported health check issue even though the service is not being used.
This PR needs a story. I have opened a PR first since I already had the change in place from looking into the issue.
Note that services as first class citizens may also solve this issue (assuming health check issues are resolved when services are unloaded due to removal from the system model).
EDIT: The
dist-datastoreis also affected by this issue.