feat: Configure LIFs and SVM on NetApp

[skrobul]

Overview

This PR implements a NetApp network configuration system that queries Nautobot for virtual machine network information and automatically creates corresponding LIF (Logical Interface) configurations on NetApp cluster. The implementation includes both a major architectural refactoring of the NetApp manager and a new Argo workflow that wraps the new functionality.

Key Features

🔧 NetApp Manager Architecture Refactoring

• Complete restructure from monolithic netapp_manager.py to a layered architecture with dependency injection
• 4-layer architecture: Manager → Services → Client → SDK for improved maintainability and testability
• Modular package structure with clear separation of concerns:
  • SvmService, VolumeService, LifService for business logic
  • NetAppClient for API abstraction
  • ErrorHandler for centralized error management and logging
  • NetAppConfig for configuration management
  • more info available in understack_workflows/docs/netapp_architecture.md

🌐 Network Configuration Workflow

• New netapp_configure_net.py script that queries Nautobot for VM network configurations
• Nautobot GraphQL integration to retrieve interface details including IP addresses and VLAN information From
• Automatic LIF creation on NetApp systems based on Nautobot data
• Configurable NIC slot prefix for environment-specific physical interface mapping

Technical Implementation

Data Flow

1. Input: OpenStack project ID (UUID format)
2. Query: Nautobot GraphQL query for device os-{project_id}
3. Validation: Ensures each interface has exactly one IP address and one VLAN
4. Creation: Automatically creates corresponding Home Ports, LIF interfaces on NetApp

Configuration

• Environment-specific settings including nic_slot_prefix must be part of the cinder-netapp-config Secret in openstack namespace.
• Credential management with fallback support

Testing & Quality

Comprehensive Test Suite

• New tests covering all components and integration scenarios
• Unit tests for each service layer with proper mocking
• Integration tests for cross-service coordination
• End-to-end workflow testing with mock Nautobot responses
• Test cleanup removing duplicate logic and architectural boundary violations

Code Quality

• Dependency injection throughout for better testability
• Type hints and dataclasses for better code clarity
• Structured logging with appropriate levels
• Error context for improved debugging

Breaking Changes

• Removed: Monolithic netapp_manager.py
• Replaced with: Modular understack_workflows.netapp package
• API compatibility: All existing NetAppManager public methods unchanged

Unfinished

You may have noticed that there is some code around the NVMe Namespaces. It is not wired in and has not been tested. Out of scope for this PR.

Command Line Testing

python -m understack_workflows.main.netapp_configure_net \
    --project-id 3c1648df945f429893b676648eddff7b \
    --nautobot-url http://nautobot.example.com \
    --nautobot-token <token>

Argo Workflow

argo -n argo-events submit --from workflowtemplate/netapp-configure-net \
  -p project_id=3c1648df945f429893b676648eddff7b

Example Results