In stepper, respect the number-display format of the language. #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To that end, call the underlying pretty-print-print-handler instead of format, and transform write-special'ed number markup into the corresponding snip.
|
I should not that the snips don't look very good, but this needs to be fixed in the framework. |
|
Is there a place to add a test case for this one?
Robby
…On Tue, Apr 29, 2025 at 6:35 AM Mike Sperber ***@***.***> wrote:
*mikesperber* left a comment (racket/htdp#246)
<#246 (comment)>
I should not that the snips don't look very good, but this needs to be
fixed in the framework.
—
Reply to this email directly, view it on GitHub
<#246 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADBNMGS62M26AGQLEY4UFL235PZXAVCNFSM6AAAAAB4CUJYP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZYGMZDIMJXGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
A meaningful test for this would have to look at the actual live UI of the stepper - I haven't seen that yet. (Or am I wrong, @jbclements ?) |
|
@mike no, there's no way to look at the live GUI output that I know of, though I can add a manual checklist item to manual-tests. You probably have an easy example that I can test? Broadly speaking: this definitely seems like an improvement. |
jbclements
approved these changes
May 3, 2025
|
@rfindler Any chance you could help with making the number snips use the same font size as the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To that end, call the underlying pretty-print-print-handler instead of format, and transform write-special'ed number markup into the corresponding snip.