Skip to content

Conversation

haroldcarr
Copy link
Contributor

subtract and subtract1 tests fail because in is missing.

Note: in is defined in redex-doc/redex/scribblings/long-tut/code/common.rkt --- but that file is used in a different part of the tutorial. At this point in the tutorial the only import is (require redex).

@wilbowma
Copy link
Collaborator

wilbowma commented Jul 4, 2017

Is there a reason to redefine this instead adding an import from common.rkt?

@haroldcarr
Copy link
Contributor Author

I would vote to putting the definition in place (rather then import) to keep the exposition self-contained up to that point. For someone new to redex it is useful to see it in isolation.

@wilbowma
Copy link
Collaborator

wilbowma commented Jul 4, 2017

Aftering reading through the tutorial more carefully, I agree. Up to this point in the tutorial, common.rkt is not mentioned, and in just comes out of no where.

I'll merge this today if there are no objections.

@mfelleisen
Copy link
Contributor

See #112

@bennn bennn merged commit 81b440a into racket:master Jul 10, 2017
rfindler pushed a commit that referenced this pull request Jul 16, 2017
(cherry picked from commit 81b440a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants