Skip to content

Commit

Permalink
Installing the Radar Cordova SDK results in the app's Podfile being o…
Browse files Browse the repository at this point in the history
…verwritten (#35)

* update plugin pod spec & bump up version

* update example

* Update xcode version to 13.4.1

* npm install in plugin/

* Change .config location

* Change .config location

* Comment out chown

---------

Co-authored-by: Tim Julien <[email protected]>
  • Loading branch information
gabrielalao and tjulien authored Oct 12, 2023
1 parent ba32967 commit 2998ca6
Show file tree
Hide file tree
Showing 7 changed files with 29 additions and 16 deletions.
10 changes: 5 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ jobs:
- run: cd example && cordova build
ios:
macos:
xcode: 13.1.0
xcode: 13.4.1
working_directory: ~/cordova-plugin-radar
steps:
- checkout:
path: ~/cordova-plugin-radar
- run: npm install
- run: sudo npm install -g cordova
- run: cd plugin && npm install
- run: cd plugin && sudo npm install -g cordova
- run: cd example && npm install
- run: sudo chown -R 502:20 "/Users/distiller/.config"
# - run: sudo chown -R 502:20 "/Users/distiller/.config"
- run: cd example && cordova platform add ios
- run: cd example && cordova plugin add ../plugin
- run: cd example && cordova build
Expand All @@ -31,4 +31,4 @@ workflows:
android-ios:
jobs:
- android
- ios
- ios
7 changes: 4 additions & 3 deletions example/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@
"cordova": {
"plugins": {
"@radarlabs/cordova-plugin-radar": {},
"cordova-plugin-radar": {}
"cordova-plugin-radar": {
"NS_LOCATION_WHEN_IN_USE_USAGE_DESCRIPTION": "This app uses your location for geofencing.",
"NS_LOCATION_ALWAYS_AND_WHEN_IN_USE_USAGE_DESCRIPTION": "This app uses your location for geofencing.",
"NS_LOCATION_ALWAYS_USAGE_DESCRIPTION": "This app uses your location for geofencing."
}
},
"platforms": [
"ios",
Expand All @@ -19,6 +23,6 @@
"devDependencies": {
"@radarlabs/cordova-plugin-radar": "file:../plugin",
"cordova-android": "^11.0.0",
"cordova-ios": "^6.2.0"
"cordova-ios": "^6.3.0"
}
}
4 changes: 2 additions & 2 deletions plugin/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Cordova plugin for Radar, the leading geofencing and location tracking platform",
"homepage": "https://radar.com",
"license": "Apache-2.0",
"version": "3.5.0",
"version": "3.5.1",
"main": "www/Radar.js",
"devDependencies": {
"babel-eslint": "^10.0.1",
Expand Down
8 changes: 6 additions & 2 deletions plugin/plugin.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<plugin xmlns="http://cordova.apache.org/ns/plugins/1.0"
id="cordova-plugin-radar"
version="3.5.0">
version="3.5.1">
<name>Radar</name>
<js-module src="www/Radar.js" name="Radar">
<clobbers target="cordova.plugins.radar"/>
Expand Down Expand Up @@ -54,6 +54,10 @@

<header-file src="src/ios/CDVRadar.h"/>
<source-file src="src/ios/CDVRadar.m"/>
<framework src="RadarSDK" type="podspec" spec="3.5.9"/>
<podspec>
<pods use-frameworks="true">
<pod name="RadarSDK" spec="3.5.9"/>
</pods>
</podspec>
</platform>
</plugin>
6 changes: 5 additions & 1 deletion plugin/plugin.xml.template
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@

<header-file src="src/ios/CDVRadar.h"/>
<source-file src="src/ios/CDVRadar.m"/>
<framework src="RadarSDK" type="podspec" spec="{{ version }}"/>
<podspec>
<pods use-frameworks="true">
<pod name="RadarSDK" spec="{{ version }}"/>
</pods>
</podspec>
</platform>
</plugin>

0 comments on commit 2998ca6

Please sign in to comment.