add addRadarSDKVerify option #367
Conversation
| @@ -59,6 +59,7 @@ export const withRadarAndroid = ( | |||
| <!-- for React Native --> | |||
| <domain-config cleartextTrafficPermitted="true"> | |||
| <domain includeSubdomains="true">localhost</domain> | |||
| <domain includeSubdomains="true">10.0.2.2</domain> | |||
There was a problem hiding this comment.
localhost on Android emulator
|
|
||
| // Insert the pod declaration within the target block | ||
| const targetBlock = contents.substring(targetStartIndex, targetEndIndex); | ||
| const updatedTargetBlock = targetBlock.replace(/(target '(\w+)' do)/, `$1\n pod 'RadarSDK/Verify', '3.19.2-beta.9'\n pod 'CocoaAsyncSocket', :modular_headers => true\n pod 'HTTPParserC', :modular_headers => true`); |
There was a problem hiding this comment.
Telegraph sub-dependencies need modular_headers => true
| const contents = await fs.readFile(filePath, 'utf-8'); | ||
|
|
||
| // Check if the pod declaration already exists | ||
| if (contents.indexOf("pod 'RadarSDK/Verify', '3.19.2-beta.9'") === -1) { |
There was a problem hiding this comment.
@lmeier @KennyHuRadar Similar to addRadarSDKMotion option. Will we need to update the version by hand in both places?
There was a problem hiding this comment.
we should probably extract this to a constant in the future. Since we release all the sdks with matching versions (I think, since RadarSDKMotion releases a 3.19 together with a 3.19 main SDK even if there is no change). We can probably just update the version string in the podspec file, and we can read the version from there and use it across the plugin.
There was a problem hiding this comment.
Yea that's exactly correct — easiest to maintain the same version across the the main module and all submodules.
|
I noticed that you bumped the RN version, however, there are a few more spots where we need to bump the beta version and the native versions as well. It's documented here
|
startVerifyServer()andstopVerifyServer(), allowing customers to turn their Android app into a "companion app" (https://radar.com/documentation/fraud#web-and-desktop) fortrackVerified()andstartTrackingVerified()on mobileaddRadarSDKVerifyplugin option to addNanoHTTPDdependency andTelegraphsub-dependencies (CocoaAsyncSocketandHTTPParserCwith:modular_headers => true)