Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

macOS Sierra and above Blocked Plugin Fix + Legacy Xcode Building #671

Merged
merged 5 commits into from
Mar 13, 2019

Conversation

BarakaAka1Only
Copy link
Contributor

Thanks to @xrubioj for pointing the his solution

This fix addresses the Blocked Plugin issue and UI properties are
usable than a blanked out UI from @xrubioj original PR
#670

Legacy Build System is needed so i enabled it in my workspace

Only if you set UseModernBuildSystem=NO in the Workspace setting

Xcode 9.3 adds a new IDEWorkspaceChecks.plist file to a workspace’s
shared data, to store the state of necessary workspace checks.
Committing this file to source control will prevent unnecessary
rerunning of those checks for each user opening the workspace.

Thanks to @xrubioj for pointing the his solution

This fix addresses the Blocked Plugin issue and UI properties are
usable than a blanked out UI from @xrubioj original PR
radiant-player#670

Legacy Build System is needed so i enabled it in my workspace

Only if you set `UseModernBuildSystem=NO` in the Workspace setting

```
Xcode 9.3 adds a new IDEWorkspaceChecks.plist file to a workspace’s
shared data, to store the state of necessary workspace checks.
Committing this file to source control will prevent unnecessary
rerunning of those checks for each user opening the workspace.
```
@jacobwgillespie
Copy link
Member

I've updated the build on Travis CI so it does produce builds again, but it seems to still be crashing - @BarakaAka1Only you want to take a look when you have a moment?

@BarakaAka1Only
Copy link
Contributor Author

@jacobwgillespie I went ahead and merged all the changes and everything passed ;)

@xrubioj
Copy link
Contributor

xrubioj commented Nov 7, 2018

@BarakaAka1Only @jacobwgillespie See issue #674 about the crash. :) I suggest to move the discussion there in order to not duplicate efforts.

@BarakaAka1Only
Copy link
Contributor Author

@jacobwgillespie @xrubioj sorry been very busy at work i went ahead and merged the branch with @xrubioj excellent fix for the crash issue so that the rest with the non-media keys and such (blocked plug-in) is fixed! (yes i've tested it before merging)

@jacobwgillespie jacobwgillespie merged commit c242bc3 into radiant-player:master Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants