Fix #7424: make all of Sirepo moderated #7426
Conversation
A trial is now required to access all of Sirepo. Every new user is moderated. All existing users will be give 30 days access. After that a paid plan will be required. 30 days after this is deployed (after all non-paid users are expired) we can remove moderating for Jupyterhub. Just the moderation for Sirepo will be enough.
| <div class="row"> | ||
| <div class="col-sm-6 col-sm-offset-2"> | ||
| <h1>Plan Required</h1> | ||
| <p>An <span data-plans-link="" link-text="active plan"></span> is required to use Sirepo.</p> |
There was a problem hiding this comment.
Why is it data-plans-link="" and not directive <data-plan-link>active plan</data-plan-link>? I.e. why is the span necessary?
There was a problem hiding this comment.
Can you create directives that way? I don't see any examples
$ grep -ri --exclude-dir='ext' '<data-' ~/src/radiasoft/sirepo/sirepo/package_data/static/
/home/vagrant/src/radiasoft/sirepo/sirepo/package_data/static/js/sirepo-beamline.js: <data-ng-include src="::iconUrl" data-onload="iconLoaded()"/>
| @@ -557,6 +564,11 @@ | |||
| } | |||
| }, | |||
| "customErrors": { | |||
| "402": { | |||
There was a problem hiding this comment.
Good use of 402. That's one code I didn't have memorized.
However, I think this is for all plan, though? I think this exception is "plan-expired" and in the case of a paid plan, it will have different text.
There was a problem hiding this comment.
My thinking is regardless of what plan (trial or premium) a user will see the same message. Do you think they should see different messages?
On the moderation page it should explain a bit about the reason for the moderation. If it is for require_plan, then it should be explain a bit about the reason why sirepo is moderated. On the registration page, we'll definitely want something about using institutional email, not gmail or yahoo. |
|
@robnagler ready for another review |
A trial is now required to access all of Sirepo. Every new user is moderated.
All existing users will be give 30 days access. After that a paid plan will be required.
30 days after this is deployed (after all non-paid users are expired) we can remove moderating for Jupyterhub. Just the moderation for Sirepo will be enough.