Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7279 full support for PNNL material database #7428

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Conversation

moellep
Copy link
Member

@moellep moellep commented Jan 20, 2025

Added a type-ahead lookup list option when defining materials.

A condensed hdf5 file can be created from the full PNNL json file using pkcli.openmc.create_standard_materials_file()

The hdf5 file is stored in the cloudmc data repo sirepo-data-cloudmc.

During geometry initialization, the PNNL cache is checked and the file is retrieved from the data repo if needed.

@moellep moellep requested a review from e-carlin January 20, 2025 23:52
Copy link
Member

@e-carlin e-carlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I run this? I tried opening the Aurora example and changing the material for copper to "Steel, Stainless 202". I then ran the sim and got this error

Could not find nuclide C12 in the nuclear data library.

@moellep
Copy link
Member Author

moellep commented Jan 21, 2025

Good point - the PNNL references nuclides which aren't present in the older ENDFB-7.0 source. I've updated the examples to use the more recent version ENDFB-8.0. You should be able to "discard changes to example" and then use the material lookup.

Copy link
Member

@e-carlin e-carlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@moellep moellep enabled auto-merge (squash) January 22, 2025 00:20
@moellep moellep merged commit 3aed459 into master Jan 22, 2025
3 checks passed
@moellep moellep deleted the 7279-materials branch January 22, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants