-
Notifications
You must be signed in to change notification settings - Fork 120
[WIP] feat(copilot): add terraform instructions #10821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] feat(copilot): add terraform instructions #10821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds initial Terraform instructions for GitHub Copilot based on guidelines from the awesome-copilot repository. The instructions provide comprehensive guidelines covering security, modularity, maintainability, style, documentation, and testing practices for Terraform configurations.
Key Changes
- Added new instruction file
.github/instructions/terraform.instructions.mdto guide Copilot in generating Terraform code - Includes sections on security, modularity, maintainability, style/formatting, documentation, and testing
- Configures instructions to apply to all
*.tffiles
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10821 +/- ##
==========================================
+ Coverage 50.42% 50.44% +0.01%
==========================================
Files 664 664
Lines 41302 41302
==========================================
+ Hits 20826 20834 +8
+ Misses 18500 18496 -4
+ Partials 1976 1972 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| ## General Instructions | ||
|
|
||
| - Use Terraform to provision and manage infrastructure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add an instruction like Use Terraform as Radius Recipes that can be used to deploy resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This instruction focusses on general terraform practices, the dedicated "Recipe" one should be separate.
35c1cd2 to
a8b986e
Compare
3d6811e to
f7cf2a4
Compare
6f7160d to
b2dc71f
Compare
b2dc71f to
44b9df1
Compare
44b9df1 to
fadc1c9
Compare
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: Dariusz Porowski <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Dariusz Porowski <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Dariusz Porowski <[email protected]>
Signed-off-by: Dariusz Porowski <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Dariusz Porowski <[email protected]>
40de8d8 to
9d3baee
Compare
Description
Adds initial instruction for
terraformbased on https://github.com/github/awesome-copilot. The goal is to use as it is and iterate over time to fine tune.All Terraform files should consistently adhere to best practices, whether they are examples or test data.
Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: