Skip to content

Conversation

@DariuszPorowski
Copy link
Member

@DariuszPorowski DariuszPorowski commented Nov 14, 2025

Description

Adds initial instruction for terraform based on https://github.com/github/awesome-copilot. The goal is to use as it is and iterate over time to fine tune.

All Terraform files should consistently adhere to best practices, whether they are examples or test data.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds initial Terraform instructions for GitHub Copilot based on guidelines from the awesome-copilot repository. The instructions provide comprehensive guidelines covering security, modularity, maintainability, style, documentation, and testing practices for Terraform configurations.

Key Changes

  • Added new instruction file .github/instructions/terraform.instructions.md to guide Copilot in generating Terraform code
  • Includes sections on security, modularity, maintainability, style/formatting, documentation, and testing
  • Configures instructions to apply to all *.tf files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.44%. Comparing base (90efc92) to head (b2dc71f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10821      +/-   ##
==========================================
+ Coverage   50.42%   50.44%   +0.01%     
==========================================
  Files         664      664              
  Lines       41302    41302              
==========================================
+ Hits        20826    20834       +8     
+ Misses      18500    18496       -4     
+ Partials     1976     1972       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


## General Instructions

- Use Terraform to provision and manage infrastructure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an instruction like Use Terraform as Radius Recipes that can be used to deploy resources?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This instruction focusses on general terraform practices, the dedicated "Recipe" one should be separate.

@DariuszPorowski DariuszPorowski force-pushed the dp/copilot-instructions-terraform branch 2 times, most recently from 35c1cd2 to a8b986e Compare November 25, 2025 00:09
@DariuszPorowski DariuszPorowski force-pushed the dp/copilot-instructions-terraform branch from 3d6811e to f7cf2a4 Compare November 25, 2025 02:18
@DariuszPorowski DariuszPorowski marked this pull request as draft November 25, 2025 02:18
@DariuszPorowski DariuszPorowski force-pushed the dp/copilot-instructions-terraform branch from 6f7160d to b2dc71f Compare November 25, 2025 02:54
@DariuszPorowski DariuszPorowski changed the title feat(copilot): add terraform instructions [WIP] feat(copilot): add terraform instructions Nov 25, 2025
@DariuszPorowski DariuszPorowski force-pushed the dp/copilot-instructions-terraform branch from b2dc71f to 44b9df1 Compare November 25, 2025 15:32
@DariuszPorowski DariuszPorowski force-pushed the dp/copilot-instructions-terraform branch from 44b9df1 to fadc1c9 Compare November 25, 2025 15:33
@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 26, 2025

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository DariuszPorowski/radius-radius
Commit ref 9185119
Unique ID func2fcb6e551f
Image tag pr-func2fcb6e551f
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func2fcb6e551f
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func2fcb6e551f
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func2fcb6e551f
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func2fcb6e551f
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func2fcb6e551f
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@DariuszPorowski DariuszPorowski force-pushed the dp/copilot-instructions-terraform branch from 40de8d8 to 9d3baee Compare December 2, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants