Add DeploymentTemplate controller for GitOps support #8001

willdavsmith · 2024-10-17T15:53:06Z

Description

Add rad bicep generate-kubernetes-manifest CLI
Add DeploymentTemplate controller
Add DeploymentResource controller

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).

#6689

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

deploy/Chart/templates/controller/deployment.yaml

willdavsmith · 2024-11-01T19:47:08Z

pkg/cli/bicep/deployment_parameters.go

-}
-
-type OSFileSystem struct {
+	FileSystem afero.Fs


instead of writing a filesystem abstraction I added this afero library. Seems to be widely used, I replaced the OSFileSystem with it. LMK if I should revert

are there added functionalities that we get using afero or is the main benefit that's it's an abstraction layer over os?

instead of writing a filesystem abstraction I added this afero library. Seems to be widely used, I replaced the OSFileSystem with it. LMK if I should revert

The afero repo appears to have no commits for a year even though there are open PRs for it, including one for a CVE. I don't see depndabot PRs being active in the list at all, which suggests that this dependency could open us up to some security issues. None of the issues created in the last year have any comments or responses. If there's a compelling reason for using this library, then let's discuss how to manage it.

On the other hand, Radius already depends on viper, which gives us an indirect dependency on afero.

Good find! I added it here because the stdlib fs does not include a filesystem abstraction with CreateFile. The benefit of adding afero was to not have to implement and maintain this ourselves. Since we already indirectly depend on this library, and that it's a pretty widespread dependency, I'd say we should be okay to use it. Thoughts? @brooke-hamilton

@rynowak thoughts on this?

What's the savings of using this library? I don't have fundamental concerns about it, I just can't tell from the diff what's going to change.

I'd also really like to remove viper as a dependency. We've got a lot of workarounds in place for for behaviors that aren't helpful to us.

I removed afero as a dependency and wrote a simple filesystem abstraction that we can use

willdavsmith · 2024-11-01T19:52:10Z

pkg/cli/cmd/deploy/deploy_test.go

@@ -527,7 +527,6 @@ func Test_Run(t *testing.T) {
 	})

 	t.Run("Deployment with missing parameters", func(t *testing.T) {
-		//t.Skip()


removing commented out t.Skip()

radius-functional-tests · 2024-11-01T20:15:51Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	willdavsmith/radius
Commit ref	`a774840`
Unique ID	func56e23e2717
Image tag	pr-func56e23e2717

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func56e23e2717
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func56e23e2717
controller test image location: ghcr.io/radius-project/dev/controller:pr-func56e23e2717
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func56e23e2717
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

bicep-types

pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest.go

pkg/controller/api/radapp.io/v1alpha3/deploymentresource_types.go

brooke-hamilton

I ran make generate build test and got 8 failures.

=== FAIL: pkg/cli/cmd/bicep/generatekubernetesmanifest Test_Run/Create_basic_DeploymentTemplate (0.00s)
=== FAIL: pkg/cli/cmd/bicep/generatekubernetesmanifest Test_Run/Create_DeploymentTemplate_with_template_content (0.00s)
=== FAIL: pkg/cli/cmd/bicep/generatekubernetesmanifest Test_Run/Create_DeploymentTemplate_with_Azure_scope (0.00s)
=== FAIL: pkg/cli/cmd/bicep/generatekubernetesmanifest Test_Run/Create_DeploymentTemplate_with_AWS_scope (0.00s)
=== FAIL: pkg/cli/cmd/bicep/generatekubernetesmanifest Test_Run (0.00s)
=== FAIL: pkg/controller/reconciler Test_DeploymentResourceReconciler_Basic (10.01s)
=== FAIL: pkg/controller/reconciler Test_DeploymentTemplateReconciler_Basic (0.01s)
=== FAIL: pkg/controller/reconciler Test_DeploymentTemplateReconciler_FailureRecovery (0.00s)

Here's one example:

=== FAIL: pkg/cli/cmd/bicep/generatekubernetesmanifest Test_Run/Create_DeploymentTemplate_with_Azure_scope (0.00s)
Creating DeploymentTemplate YAML file
    generatekubernetesmanifest_test.go:396: 
                Error Trace:    /workspaces/radius/pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest_test.go:396
                Error:          Not equal: 
                                expected: "apiVersion: radapp.io/v1alpha3\nkind: DeploymentTemplate\nmetadata:\n  name: azure.yaml\n  namespace: radius-system\nspec:\n  parameters: '{}'\n  providerConfig: '{\"radius\":{\"type\":\"radius\",\"value\":{\"scope\":\"/planes/radius/local/resourceGroups/test-resource-group\"}},\"az\":{\"type\":\"azure\",\"value\":{\"scope\":\"/subscriptions/test-subId/resourceGroups/test-rg\"}},\"deployments\":{\"type\":\"Microsoft.Resources\",\"value\":{\"scope\":\"/planes/radius/local/resourceGroups/test-resource-group\"}}}'\n  template: '{}'\n"
                                actual  : "apiVersion: radapp.io/v1alpha3\nkind: DeploymentTemplate\nmetadata:\n  name: azure.yaml\n  namespace: radius-system\nspec:\n  parameters: '{}'\n  providerConfig: '{\"radius\":{\"type\":\"radius\",\"value\":{\"scope\":\"/planes/radius/local/resourceGroups/test-resource-group\"}},\"az\":{\"type\":\"azure\",\"value\":{\"scope\":\"/subscriptions/test-subId/resourceGroups/test-rg\"}},\"deployments\":{\"type\":\"Microsoft.Resources\",\"value\":{\"scope\":\"/planes/radius/local/resourceGroups/test-resource-group\"}}}'\n  repository: azure.yaml\n  template: '{}'\n"
                            
                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -8,2 +8,3 @@
                                   providerConfig: '{"radius":{"type":"radius","value":{"scope":"/planes/radius/local/resourceGroups/test-resource-group"}},"az":{"type":"azure","value":{"scope":"/subscriptions/test-subId/resourceGroups/test-rg"}},"deployments":{"type":"Microsoft.Resources","value":{"scope":"/planes/radius/local/resourceGroups/test-resource-group"}}}'
                                +  repository: azure.yaml
                                   template: '{}'
                Test:           Test_Run/Create_DeploymentTemplate_with_Azure_scope
    --- FAIL: Test_Run/Create_DeploymentTemplate_with_Azure_scope (0.00s)

brooke-hamilton

Running make generate results in these files being changed.

deploy/Chart/crds/radius/radapp.io_deploymentresources.yaml
deploy/Chart/crds/radius/radapp.io_deploymenttemplates.yaml
deploy/Chart/crds/radius/radapp.io_recipes.yaml
deploy/Chart/crds/ucpd/ucp.dev_queuemessages.yaml
deploy/Chart/crds/ucpd/ucp.dev_resources.yaml

For example, controller-gen.kubebuilder.io/version: v0.16.4 changes to controller-gen.kubebuilder.io/version: v0.16.0

Signed-off-by: willdavsmith <[email protected]>

radius-functional-tests · 2025-01-13T23:21:55Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	willdavsmith/radius
Commit ref	`5585544`
Unique ID	func099fbe1177
Image tag	pr-func099fbe1177

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func099fbe1177
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func099fbe1177
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func099fbe1177
controller test image location: ghcr.io/radius-project/dev/controller:pr-func099fbe1177
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func099fbe1177
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
❌ Test tool installation for ucp-cloud failed. Please check the logs for more details
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

Signed-off-by: willdavsmith <[email protected]>

ytimocin · 2025-01-14T00:50:20Z

pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest.go

+	commonflags.AddResourceGroupFlag(cmd)
+	commonflags.AddParameterFlag(cmd)
+
+	cmd.Flags().StringP("destination-file", "d", "", "Path of the generated DeploymentTemplate yaml file.")


Is this the file to be generated by the command? Should it be existing before running the command? The description may need an update.

updated the description: "Path of the generated DeploymentTemplate yaml file created by running this command."

ytimocin · 2025-01-14T00:50:39Z

pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest.go

+	AWSScope        string
+}
+
+// NewRunner creates a new instance of the `rad deploy` runner.


needs an update

ytimocin · 2025-01-14T00:51:46Z

pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest.go

+		r.DestinationFile = strings.TrimSuffix(filepath.Base(r.FilePath), filepath.Ext(r.FilePath)) + ".yaml"
+	}
+
+	if filepath.Ext(r.DestinationFile) != ".yaml" {


Would this be a problem if some provides .yml as the extension?

updated to accept both

ytimocin · 2025-01-14T00:52:15Z

pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest.go

+		return err
+	}
+
+	// Print the path to the file


Do we need this comment?

ytimocin · 2025-01-14T00:53:09Z

pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest.go

+	var buf bytes.Buffer
+	encoder := yaml.NewEncoder(&buf)
+
+	// Set the indentation to 2 spaces


nit: not necessary because code is clear enough

ytimocin · 2025-01-14T00:54:12Z

pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest.go

+			},
+		}
+	}
+	if r.Group != "" {


If group is empty at this point, then we have a problem, right? I mean according to the code this case shouldn't happen but just asking.

ytimocin · 2025-01-14T00:55:20Z

pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest_test.go

+		},
+		{
+			Name:          "rad bicep generate-kubernetes-manifest - valid with group long flag",
+			Input:         []string{"app.bicep", "--group", "default"},


No group should also be tested.

added the test

ytimocin · 2025-01-14T00:56:22Z

pkg/cli/cmd/recipe/register/register.go

-	parser := bicep.ParameterParser{FileSystem: bicep.OSFileSystem{}}
+	parser := bicep.ParameterParser{FileSystem: filesystem.NewOSFS()}


What is the main reason of this change?

I needed a filesystem abstraction that handles CreateFile since rad bicep generate-kubernetes-manifest creates a file. Instead of using a library, I wrote a simple one. See more info here: #8001 (comment)

ytimocin · 2025-01-14T00:58:08Z

pkg/cli/filesystem/memmapfs_test.go

+
+	_, _ = fs.Create(fileName)
+
+	file, err := fs.Open(fileName)


Do any of the functions in the MemMapFileSystem need a defer close or something like that when called?

no, because they aren't actually opening a file, they're just adding content to a map in memory. This is useful for testing

ytimocin · 2025-01-14T00:58:44Z

pkg/cli/filesystem/osfs.go

Is this supposed to have unit tests?

These are just a wrapper over the os functions so I don't think unit tests are necessary.

radius-functional-tests · 2025-01-14T05:35:09Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	willdavsmith/radius
Commit ref	`876ea07`
Unique ID	func626dc81863
Image tag	pr-func626dc81863

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func626dc81863
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func626dc81863
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func626dc81863
controller test image location: ghcr.io/radius-project/dev/controller:pr-func626dc81863
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func626dc81863
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

sk593 · 2025-01-15T22:00:07Z

pkg/cli/filesystem/osfs.go

+	return &OSFileSystem{}
+}
+
+func (osfs OSFileSystem) Create(name string) (fs.File, error) {


Should we have unit testing for this abstraction? There is testing forMemMapFS

These are just a wrapper over the os functions so I don't think unit tests are necessary.

sk593 · 2025-01-15T22:01:32Z

pkg/cli/filesystem/filesystem.go

+	"io/fs"
+)
+
+// FileSystem is an interface that defines the methods needed to interact with a file system.


Could you explain the use cases for OSFS and MemMapFS? It seems like MemMapFS is only used for testing while OSFS is used when generating the manifest files. Is MemMapFS used to make testing the generate manifest code easier?

That's correct. In the real world (when a user runs the command), they expect to have the file generated for them on their OS filesystem (so we use OSFS). Since we don't want to have a whole OS filesystem for unit tests we can just use the MemMapFS.

sk593 · 2025-01-15T22:32:44Z

test/functional-portable/kubernetes/noncloud/deploymenttemplate_test.go

+}
+
+func waitForDeploymentTemplateReady(t *testing.T, ctx context.Context, name types.NamespacedName, client controller_runtime.WithWatch, initialVersion string) (*radappiov1alpha3.DeploymentTemplate, error) {
+	// Based on https://gist.github.com/PrasadG193/52faed6499d2ec739f9630b9d044ffdc


Can you add comments for what this code does

sk593 · 2025-01-15T23:43:55Z

test/functional-portable/kubernetes/noncloud/deploymenttemplate_test.go

+	controller_runtime "sigs.k8s.io/controller-runtime/pkg/client"
+)
+
+func Test_DeploymentTemplate_Basic(t *testing.T) {


Suggested change

func Test_DeploymentTemplate_Basic(t *testing.T) {

func Test_DeploymentTemplate_Env(t *testing.T) {

so it lines up with the file name?

sk593 · 2025-01-17T19:16:57Z

pkg/controller/reconciler/shared_test.go

-func createEnvironment(radius *mockRadiusClient, name string) {
-	id := fmt.Sprintf("/planes/radius/local/resourceGroups/%s/providers/Applications.Core/environments/%s", name, name)
+func createEnvironment(radius *mockRadiusClient, resourceGroup, name string) {
+	id := fmt.Sprintf("/planes/radius/local/resourceGroups/%s/providers/Applications.Core/environments/%s", resourceGroup, name)


Just confirming, did we add the RG because we create one if it doesn't exist as part of the deployment template controller?

yep, also just for clarity

sk593 · 2025-01-17T21:53:59Z

pkg/controller/reconciler/testdata/deploymenttemplate-withresources.json

+            "resourceId": "self",
+            "namespace": "default"
+          }
+        }


Do we need to test for different provider configs?

for now I think this is okay. it'll take some work to add these tests, we can do it later.

This PR is already large enough :)

lakshmimsft · 2025-01-23T23:35:41Z

pkg/controller/reconciler/deploymenttemplate_reconciler.go

+				existingOutputResources[resource] = true
+			}
+
+			newOutputResources := make(map[string]bool)


I did not see a test for this functionality (could it be pulled out)?

added a test

lakshmimsft · 2025-01-23T23:44:58Z

pkg/controller/reconciler/deploymentresource_reconciler.go

@@ -0,0 +1,393 @@
+/*
+Copyright 2024 The Radius Authors.


Some files have this as 2024 while most have 2023. May not be of consequence but good to be consistent.

I'll just put 2024 for now since this is the same as the other reconciler files

lakshmimsft · 2025-01-23T23:46:32Z

pkg/cli/filesystem/filesystem.go

@@ -0,0 +1,15 @@
+package filesystem


Missing copyright text in some new files

lakshmimsft · 2025-01-23T23:57:47Z

Is it possible to have a multi-step test where where we deploy a template file and check it's updated and then we deploy an updated file for the same template with updated resources and check for correct update? That may be a way to test the updates to outputresources unless there was another way that exists and I missed it.

Signed-off-by: willdavsmith <[email protected]>

willdavsmith · 2025-01-24T01:53:49Z

Is it possible to have a multi-step test where where we deploy a template file and check it's updated and then we deploy an updated file for the same template with updated resources and check for correct update? That may be a way to test the updates to outputresources unless there was another way that exists and I missed it.

yep, just added one! good callout

Signed-off-by: willdavsmith <[email protected]>

radius-functional-tests · 2025-01-24T01:57:48Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	willdavsmith/radius
Commit ref	`42f750b`
Unique ID	func44f976690b
Image tag	pr-func44f976690b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func44f976690b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func44f976690b
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func44f976690b
controller test image location: ghcr.io/radius-project/dev/controller:pr-func44f976690b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func44f976690b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

fixed!

sk593 reviewed Oct 21, 2024

View reviewed changes

deploy/Chart/templates/controller/deployment.yaml Outdated Show resolved Hide resolved

sk593 mentioned this pull request Oct 24, 2024

[wip - do not review] Add bicep as init container for controller pod #8002

Closed

6 tasks

willdavsmith commented Nov 1, 2024

View reviewed changes

willdavsmith changed the title ~~[WIP/ Do not review] Flux support~~ Add DeploymentTemplate controller Nov 1, 2024

willdavsmith marked this pull request as ready for review November 1, 2024 20:14

willdavsmith requested review from a team as code owners November 1, 2024 20:14

willdavsmith temporarily deployed to functional-tests November 1, 2024 20:15 — with GitHub Actions Inactive

sk593 reviewed Nov 4, 2024

View reviewed changes

bicep-types Outdated Show resolved Hide resolved

sk593 reviewed Nov 7, 2024

View reviewed changes

pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest.go Outdated Show resolved Hide resolved

sk593 reviewed Nov 7, 2024

View reviewed changes

pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest.go Outdated Show resolved Hide resolved

sk593 reviewed Nov 7, 2024

View reviewed changes

pkg/cli/cmd/bicep/generatekubernetesmanifest/generatekubernetesmanifest.go Show resolved Hide resolved

sk593 reviewed Nov 7, 2024

View reviewed changes

pkg/controller/api/radapp.io/v1alpha3/deploymentresource_types.go Show resolved Hide resolved

brooke-hamilton requested changes Nov 8, 2024

View reviewed changes

brooke-hamilton previously requested changes Nov 8, 2024

View reviewed changes

willdavsmith added 13 commits November 21, 2024 11:22

working

af3498c

Signed-off-by: willdavsmith <[email protected]>

deletion works

c3534bf

Signed-off-by: willdavsmith <[email protected]>

who watches the watcher

af0d1bc

Signed-off-by: willdavsmith <[email protected]>

controller-gen update

d94f505

Signed-off-by: willdavsmith <[email protected]>

PR

5a47396

Signed-off-by: willdavsmith <[email protected]>

it works

2b3e3ba

Signed-off-by: willdavsmith <[email protected]>

fixing bugs

5a60fb9

Signed-off-by: willdavsmith <[email protected]>

reconcile app

df3eb33

Signed-off-by: willdavsmith <[email protected]>

gkm tests

643d38a

Signed-off-by: willdavsmith <[email protected]>

PR

964f7d6

Signed-off-by: willdavsmith <[email protected]>

removing fluxcontroller

2b31fb7

Signed-off-by: willdavsmith <[email protected]>

FTs

59ec01d

Signed-off-by: willdavsmith <[email protected]>

FTs

22a28e0

Signed-off-by: willdavsmith <[email protected]>

willdavsmith temporarily deployed to functional-tests January 13, 2025 23:21 — with GitHub Actions Inactive

willdavsmith added 2 commits January 13, 2025 15:56

re-run

1fb419b

Signed-off-by: willdavsmith <[email protected]>

re-run

876ea07

Signed-off-by: willdavsmith <[email protected]>

ytimocin reviewed Jan 14, 2025

View reviewed changes

willdavsmith temporarily deployed to publish-bicep January 14, 2025 04:11 — with GitHub Actions Inactive

willdavsmith temporarily deployed to functional-tests January 14, 2025 05:33 — with GitHub Actions Inactive

sk593 reviewed Jan 15, 2025

View reviewed changes

sk593 reviewed Jan 17, 2025

View reviewed changes

lakshmimsft reviewed Jan 23, 2025

View reviewed changes

PR

2840562

Signed-off-by: willdavsmith <[email protected]>

PR

fe35764

Signed-off-by: willdavsmith <[email protected]>

willdavsmith had a problem deploying to publish-bicep January 24, 2025 01:54 — with GitHub Actions Error

Merge branch 'main' into deploymenttemplatecontroller

42f750b

willdavsmith temporarily deployed to publish-bicep January 24, 2025 01:55 — with GitHub Actions Inactive

willdavsmith requested review from lakshmimsft, ytimocin and sk593 January 24, 2025 01:56

willdavsmith deployed to functional-tests January 24, 2025 01:56 — with GitHub Actions Active

		parser := bicep.ParameterParser{FileSystem: bicep.OSFileSystem{}}
		parser := bicep.ParameterParser{FileSystem: filesystem.NewOSFS()}

	func Test_DeploymentTemplate_Basic(t *testing.T) {
	func Test_DeploymentTemplate_Env(t *testing.T) {

Add DeploymentTemplate controller for GitOps support #8001

Are you sure you want to change the base?

Add DeploymentTemplate controller for GitOps support #8001

Conversation

willdavsmith commented Oct 17, 2024 • edited Loading

Description

Type of change

Contributor checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brooke-hamilton Nov 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Nov 1, 2024 • edited Loading

Radius functional test overview

Test Status

brooke-hamilton left a comment • edited Loading

Choose a reason for hiding this comment

brooke-hamilton left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 13, 2025 • edited Loading

Radius functional test overview

Test Status

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 14, 2025 • edited Loading

Radius functional test overview

Test Status

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sk593 Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lakshmimsft commented Jan 23, 2025 • edited Loading

willdavsmith commented Jan 24, 2025

radius-functional-tests bot commented Jan 24, 2025 • edited Loading

Radius functional test overview

Test Status

willdavsmith commented Oct 17, 2024 •

edited

Loading

brooke-hamilton Nov 8, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 1, 2024 •

edited

Loading

brooke-hamilton left a comment •

edited

Loading

radius-functional-tests bot commented Jan 13, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 14, 2025 •

edited

Loading

sk593 Jan 15, 2025 •

edited

Loading

lakshmimsft commented Jan 23, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading