Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add purge job for bicep artifacts #8281

Merged
merged 12 commits into from
Jan 27, 2025
Merged

Add purge job for bicep artifacts #8281

merged 12 commits into from
Jan 27, 2025

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Jan 23, 2025

Description

This adds a purge job for test bicep artifacts. It will delete any manifests that are older than 90 days. This only applies to the test schemas uploaded as part of PRs, not any major release versions of Radius or AWS bicep types.

A successful test run can be found here: https://github.com/radius-project/radius/actions/runs/12939411131

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@sk593 sk593 requested a deployment to functional-tests January 23, 2025 17:14 — with GitHub Actions Waiting
@sk593 sk593 mentioned this pull request Jan 23, 2025
6 tasks
Copy link

github-actions bot commented Jan 23, 2025

Unit Tests

3 552 tests  ±0   3 548 ✅ ±0   5m 23s ⏱️ -7s
  292 suites ±0       4 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 4794a43. ± Comparison against base commit b4f1759.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.84%. Comparing base (b4f1759) to head (4794a43).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8281      +/-   ##
==========================================
+ Coverage   59.82%   59.84%   +0.01%     
==========================================
  Files         590      590              
  Lines       39513    39513              
==========================================
+ Hits        23639    23645       +6     
+ Misses      14114    14111       -3     
+ Partials     1760     1757       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
@sk593 sk593 requested a deployment to functional-tests January 23, 2025 23:03 — with GitHub Actions Waiting
@sk593 sk593 marked this pull request as ready for review January 23, 2025 23:03
@sk593 sk593 requested review from a team as code owners January 23, 2025 23:03
- name: Login to Azure
uses: azure/login@v2
with:
client-id: ${{ secrets.BICEPTYPES_CLIENT_ID }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need separate accounts for different operations? The other purge action uses AZURE_SP_TESTS_APPID. Wouldn't having one shared be better for actions that can be grouped together?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ACR is in a different account than the other Azure resources so we need different credentials to authenticate

@sk593 sk593 temporarily deployed to functional-tests January 27, 2025 17:32 — with GitHub Actions Inactive
willdavsmith
willdavsmith previously approved these changes Jan 27, 2025
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 27, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref cd0ea19
Unique ID funce27d9f6155
Image tag pr-funce27d9f6155
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce27d9f6155
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce27d9f6155
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funce27d9f6155
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funce27d9f6155
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce27d9f6155
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@sk593 sk593 dismissed stale reviews from willdavsmith and brooke-hamilton via e75c559 January 27, 2025 18:12
Signed-off-by: sk593 <[email protected]>
@sk593 sk593 temporarily deployed to functional-tests January 27, 2025 18:13 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 27, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref e75c559
Unique ID funcec8f012674
Image tag pr-funcec8f012674
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcec8f012674
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcec8f012674
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcec8f012674
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcec8f012674
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcec8f012674
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

kachawla
kachawla previously approved these changes Jan 27, 2025
Signed-off-by: sk593 <[email protected]>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 27, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref afb8301
Unique ID funcae8f4dc6ba
Image tag pr-funcae8f4dc6ba
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcae8f4dc6ba
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcae8f4dc6ba
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcae8f4dc6ba
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcae8f4dc6ba
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcae8f4dc6ba
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 27, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref ff2edf8
Unique ID func0efd1c151a
Image tag pr-func0efd1c151a
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func0efd1c151a
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func0efd1c151a
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func0efd1c151a
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func0efd1c151a
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func0efd1c151a
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@sk593 sk593 temporarily deployed to functional-tests January 27, 2025 19:19 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 27, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 9bf8381
Unique ID func41e0063dd9
Image tag pr-func41e0063dd9
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func41e0063dd9
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func41e0063dd9
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func41e0063dd9
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func41e0063dd9
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func41e0063dd9
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@sk593 sk593 temporarily deployed to functional-tests January 27, 2025 19:40 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 27, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 4794a43
Unique ID func49d764e9cc
Image tag pr-func49d764e9cc
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func49d764e9cc
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func49d764e9cc
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func49d764e9cc
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func49d764e9cc
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func49d764e9cc
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded

@sk593 sk593 merged commit c155a90 into main Jan 27, 2025
32 checks passed
@sk593 sk593 deleted the purge-bicep-artifacts branch January 27, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants