remove hardcoded list of resource types from cli. #8286

nithyatsu · 2025-01-23T21:22:54Z

Description

Since we now register resource provider manifests at startup and are in process of enabling UDT end to end, we should not use static resource type lists.

This PR removes static resource type lists in cli code.

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).

Part of #6688

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
- [X ] Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
- Yes
- [X ] Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
- Yes
- [ X] Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
- Yes
- [X ] Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
- Yes
- [X ] Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
- Yes
- [ X] Not applicable

codecov · 2025-01-24T00:42:55Z

Codecov Report

Attention: Patch coverage is 66.95652% with 38 lines in your changes missing coverage. Please review.

Project coverage is 59.88%. Comparing base (8e6d5ff) to head (16b0589).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cli/clients/management.go	56.25%	14 Missing and 7 partials ⚠️
pkg/cli/cmd/resource/delete/delete.go	41.66%	7 Missing ⚠️
pkg/cli/clivalidation.go	80.00%	3 Missing and 1 partial ⚠️
pkg/cli/cmd/resource/create/create.go	50.00%	2 Missing and 1 partial ⚠️
pkg/cli/cmd/resource/list/list.go	72.72%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8286      +/-   ##
==========================================
- Coverage   59.94%   59.88%   -0.07%     
==========================================
  Files         596      596              
  Lines       40432    40454      +22     
==========================================
- Hits        24238    24225      -13     
- Misses      14367    14408      +41     
+ Partials     1827     1821       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2025-01-24T21:15:31Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`303cf36`
Unique ID	func172c46f57a
Image tag	pr-func172c46f57a

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func172c46f57a
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func172c46f57a
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func172c46f57a
controller test image location: ghcr.io/radius-project/dev/controller:pr-func172c46f57a
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func172c46f57a
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2025-01-24T22:16:12Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`2434061`
Unique ID	funcbbf2770f0e
Image tag	pr-funcbbf2770f0e

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcbbf2770f0e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcbbf2770f0e
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcbbf2770f0e
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcbbf2770f0e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcbbf2770f0e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2025-01-24T23:09:58Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`f21c211`
Unique ID	func5b15493f3d
Image tag	pr-func5b15493f3d

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func5b15493f3d
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func5b15493f3d
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func5b15493f3d
controller test image location: ghcr.io/radius-project/dev/controller:pr-func5b15493f3d
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func5b15493f3d
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2025-01-24T23:56:25Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`afa6423`
Unique ID	func9145f55183
Image tag	pr-func9145f55183

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func9145f55183
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func9145f55183
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func9145f55183
controller test image location: ghcr.io/radius-project/dev/controller:pr-func9145f55183
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func9145f55183
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

pkg/cli/clients/management.go

pkg/cli/clients/management_test.go

ytimocin · 2025-01-25T00:59:07Z

pkg/cli/clivalidation.go

-	} else if len(foundTypes) > 1 {
-		return "", fmt.Errorf("multiple resource types match '%s'. Please specify the full resource type and try again:\n\n%s\n",
-			resourceTypeName, strings.Join(foundTypes, "\n"))
+	if !strings.Contains(resourceTypeName, "/") {


Is this the only check for the resource type?

yes. Rest of the check has to happen in "Run", since we cant test statically for anything other than the format rp/rt

pkg/cli/cmd/resource/create/create.go

pkg/cli/cmd/resource/list/list.go

radius-functional-tests · 2025-01-30T23:53:50Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`84cdb59`
Unique ID	funce5836dc593
Image tag	pr-funce5836dc593

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce5836dc593
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce5836dc593
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funce5836dc593
controller test image location: ghcr.io/radius-project/dev/controller:pr-funce5836dc593
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce5836dc593
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2025-01-30T23:55:53Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`b8e9b2a`
Unique ID	func677bb70509
Image tag	pr-func677bb70509

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func677bb70509
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func677bb70509
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func677bb70509
controller test image location: ghcr.io/radius-project/dev/controller:pr-func677bb70509
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func677bb70509
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

lakshmimsft · 2025-01-31T18:08:12Z

pkg/cli/cmd/resource/create/create.go

@@ -99,8 +99,12 @@ func (r *Runner) Validate(cmd *cobra.Command, args []string) error {
 		return err
 	}
 	r.Format = format
+	resourceProviderName, respurceTypeName, err := cli.RequireFullyQualifiedResourceType(args)


nit: typo on resourceTypeName

lakshmimsft · 2025-01-31T19:40:58Z

/LGTM overall

nithyatsu temporarily deployed to publish-bicep January 23, 2025 21:23 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 23, 2025 23:42 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 24, 2025 00:15 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 24, 2025 00:29 — with GitHub Actions Inactive

nithyatsu force-pushed the cleanup_cli branch from 4ec7b77 to 3c5e6e0 Compare January 24, 2025 16:47

nithyatsu temporarily deployed to publish-bicep January 24, 2025 16:47 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 24, 2025 18:03 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 24, 2025 19:36 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 24, 2025 19:54 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 24, 2025 21:14 — with GitHub Actions Inactive

nithyatsu force-pushed the cleanup_cli branch from 303cf36 to d18246c Compare January 24, 2025 21:55

nithyatsu temporarily deployed to publish-bicep January 24, 2025 21:55 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 24, 2025 22:11 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 24, 2025 22:15 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 24, 2025 22:26 — with GitHub Actions Inactive

nithyatsu had a problem deploying to publish-bicep January 24, 2025 22:53 — with GitHub Actions Error

nithyatsu marked this pull request as ready for review January 24, 2025 22:54

nithyatsu requested review from a team as code owners January 24, 2025 22:54

nithyatsu temporarily deployed to publish-bicep January 24, 2025 22:54 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 24, 2025 23:09 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 24, 2025 23:33 — with GitHub Actions Inactive

nithyatsu temporarily deployed to publish-bicep January 24, 2025 23:46 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 24, 2025 23:55 — with GitHub Actions Inactive

ytimocin requested changes Jan 25, 2025

View reviewed changes

nithyatsu added 10 commits January 30, 2025 13:58

nit

9fd9f9b

review comments

ead3187

wip

e727abc

wip

40fccc2

renaming nits

be48150

add RequireFullyQualifiedResourceType function

4c054e5

refactor rad resource-type to use new clivalidations

0a763e0

update commands to use new functions

9ebe247

add method

87b59f3

add a non existant resource type test

bfeac33

nithyatsu force-pushed the cleanup_cli branch from 89460e1 to bfeac33 Compare January 30, 2025 21:59

nithyatsu temporarily deployed to publish-bicep January 30, 2025 21:59 — with GitHub Actions Inactive

nit

08381bb

nithyatsu temporarily deployed to publish-bicep January 30, 2025 22:13 — with GitHub Actions Inactive

nithyatsu requested review from kachawla and ytimocin January 30, 2025 22:13

wip

84cdb59

nithyatsu temporarily deployed to publish-bicep January 30, 2025 23:08 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 30, 2025 23:53 — with GitHub Actions Inactive

remove unused function

b8e9b2a

nithyatsu temporarily deployed to publish-bicep January 30, 2025 23:54 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 30, 2025 23:54 — with GitHub Actions Inactive

nit

e754792

nithyatsu temporarily deployed to publish-bicep January 31, 2025 17:48 — with GitHub Actions Inactive

lakshmimsft reviewed Jan 31, 2025

View reviewed changes

wip

16b0589

nithyatsu temporarily deployed to publish-bicep January 31, 2025 18:49 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove hardcoded list of resource types from cli. #8286

remove hardcoded list of resource types from cli. #8286

nithyatsu commented Jan 23, 2025 •

edited by kachawla

Loading

codecov bot commented Jan 24, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading

ytimocin Jan 25, 2025

nithyatsu Jan 30, 2025

radius-functional-tests bot commented Jan 30, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 30, 2025 •

edited

Loading

lakshmimsft Jan 31, 2025

lakshmimsft commented Jan 31, 2025

remove hardcoded list of resource types from cli. #8286

Are you sure you want to change the base?

remove hardcoded list of resource types from cli. #8286

Conversation

nithyatsu commented Jan 23, 2025 • edited by kachawla Loading

Description

Type of change

Contributor checklist

codecov bot commented Jan 24, 2025 • edited Loading

Codecov Report

radius-functional-tests bot commented Jan 24, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 24, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 24, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 24, 2025 • edited Loading

Radius functional test overview

Test Status

ytimocin Jan 25, 2025

Choose a reason for hiding this comment

nithyatsu Jan 30, 2025

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 30, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 30, 2025 • edited Loading

Radius functional test overview

Test Status

lakshmimsft Jan 31, 2025

Choose a reason for hiding this comment

lakshmimsft commented Jan 31, 2025

nithyatsu commented Jan 23, 2025 •

edited by kachawla

Loading

codecov bot commented Jan 24, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 24, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 30, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 30, 2025 •

edited

Loading