Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow conditions to enable workflow_dispatch with new build #8563

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

lakshmimsft
Copy link
Contributor

Description

This pull request updates the conditions for generating an ID.

  • Updated the condition to check if the SKIP_BUILD output is not "true" instead of current check if it is empty (since we now include a manual input in workflow_dispatch mode which can be set to 'false').
  • Added an additional condition to include workflow_dispatch events for appending the run number to the unique ID.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue Investigate 409 error in Long Running tests #8449
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #8449

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@radius-functional-tests
Copy link

radius-functional-tests bot commented Feb 18, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref 532e2d7
Unique ID func562ca7e0ab
Image tag pr-func562ca7e0ab
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func562ca7e0ab
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func562ca7e0ab
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func562ca7e0ab
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func562ca7e0ab
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func562ca7e0ab
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.89%. Comparing base (83d8a72) to head (532e2d7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8563      +/-   ##
==========================================
+ Coverage   59.85%   59.89%   +0.03%     
==========================================
  Files         596      596              
  Lines       40512    40512              
==========================================
+ Hits        24249    24264      +15     
+ Misses      14431    14421      -10     
+ Partials     1832     1827       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lakshmimsft lakshmimsft merged commit 10c45d7 into radius-project:main Feb 18, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate 409 error in Long Running tests
2 participants