Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove helm chart uploads to ACR #8565

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Remove helm chart uploads to ACR #8565

merged 1 commit into from
Feb 18, 2025

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Feb 18, 2025

Description

We push Radius helm charts on merges to main to GHCR and ACR. We only need to push to GHCR. The ACR commands that we use are deprecated, causing errors in the helm chart upload. See below:

Run az acr helm push --name radius ./dist/Charts/helm/radius-0.42.42-dev.tgz --force
WARNING: This command has been deprecated and will be removed in future release. Use 'Helm v3 commands' instead. Learn more about storing Helm charts at https://aka.ms/acr/helm
WARNING: This command is implicitly deprecated because command group 'acr helm' is deprecated and will be removed in a future release. Use 'Helm v3 commands' instead.
ERROR: 2025-02-18 [21](https://github.com/radius-project/radius/actions/runs/13400072813/job/37428811515#step:9:22):13:31.102149 Error: The operation is disallowed on this registry, repository or image. View troubleshooting steps at https://aka.ms/acr/faq/#why-does-my-pull-or-push-request-fail-with-disallowed-operation-.

This change removes the upload to ACR

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@sk593 sk593 requested review from a team as code owners February 18, 2025 22:17
@sk593 sk593 temporarily deployed to functional-tests February 18, 2025 22:17 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Feb 18, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref ddf6999
Unique ID funcfcf978701c
Image tag pr-funcfcf978701c
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcfcf978701c
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcfcf978701c
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcfcf978701c
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcfcf978701c
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcfcf978701c
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link

Unit Tests

3 625 tests  ±0   3 623 ✅ ±0   6m 24s ⏱️ -8s
  295 suites ±0       2 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit ddf6999. ± Comparison against base commit 10c45d7.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.89%. Comparing base (10c45d7) to head (ddf6999).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8565   +/-   ##
=======================================
  Coverage   59.88%   59.89%           
=======================================
  Files         596      596           
  Lines       40512    40512           
=======================================
+ Hits        24261    24264    +3     
+ Misses      14423    14421    -2     
+ Partials     1828     1827    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sk593 sk593 merged commit bf7dcc1 into main Feb 18, 2025
32 checks passed
@sk593 sk593 deleted the remove-helm-acr-push branch February 18, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants