Removing unnecessary env vars from the LR workflow #8725

ytimocin · 2025-03-03T23:17:35Z

Description

Removing unnecessary environment variables from the LR workflow for cleaning up some of the code.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
- Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
- Yes
- Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
- Yes
- Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
- Yes
- Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
- Yes
- Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
- Yes
- Not applicable

github-actions · 2025-03-03T23:28:56Z

Unit Tests

3 625 tests ±0 3 623 ✅ ±0 6m 19s ⏱️ -3s
295 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit c446c7a. ± Comparison against base commit d247367.

♻️ This comment has been updated with latest results.

codecov · 2025-03-04T00:09:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.90%. Comparing base (bbb1d24) to head (c446c7a).
Report is 56 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8725      +/-   ##
==========================================
+ Coverage   59.88%   59.90%   +0.01%     
==========================================
  Files         596      596              
  Lines       40512    40512              
==========================================
+ Hits        24261    24267       +6     
+ Misses      14423    14419       -4     
+ Partials     1828     1826       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lakshmimsft · 2025-03-04T00:34:55Z

.github/workflows/long-running-azure.yaml

            echo "RAD_CLI_ARTIFACT_NAME=rad_cli_linux_amd64" >> $GITHUB_OUTPUT
-            echo "PR_NUMBER=${{ env.PR_NUMBER }}" >> $GITHUB_OUTPUT
+            echo "BICEP_RECIPE_TAG_VERSION=pr-${UNIQUE_ID}" >> $GITHUB_OUTPUT  # Add this line


nit: we do not need " # Add this line"

Signed-off-by: ytimocin <[email protected]>

kachawla · 2025-03-04T18:43:06Z

.github/workflows/long-running-azure.yaml

  # Container registry for storing container images
  CONTAINER_REGISTRY: ghcr.io/radius-project/dev
  # Container registry for storing Bicep recipe artifacts
  BICEP_RECIPE_REGISTRY: ghcr.io/radius-project/dev
  # The radius functional test timeout
-  FUNCTIONALTEST_TIMEOUT: 60m
+  TEST_TIMEOUT: 60m


Curious why are we changing this?

kachawla · 2025-03-04T18:44:56Z

.github/workflows/long-running-azure.yaml

@@ -110,16 +103,17 @@ jobs:
      SKIP_BUILD: ${{ steps.skip-build.outputs.SKIP_BUILD }}
      REL_VERSION: ${{ steps.gen-id.outputs.REL_VERSION }}
      UNIQUE_ID: ${{ steps.gen-id.outputs.UNIQUE_ID }}
-      PR_NUMBER: ${{ steps.gen-id.outputs.PR_NUMBER }}


Was this not being used?

kachawla · 2025-03-04T18:50:01Z

.github/workflows/long-running-azure.yaml

            echo "RAD_CLI_ARTIFACT_NAME=rad_cli_linux_amd64" >> $GITHUB_OUTPUT
-            echo "PR_NUMBER=${{ env.PR_NUMBER }}" >> $GITHUB_OUTPUT
+            echo "BICEP_RECIPE_TAG_VERSION=pr-${UNIQUE_ID}" >> $GITHUB_OUTPUT


What's the motivation to move it to uuid instead of release version?

kachawla

Are some of these changes applicable to the functional tests workflow as well?

kachawla

Was there a testing issue in creating this PR from a fork?

kachawla · 2025-04-15T16:35:51Z

@ytimocin could you take a look at the PR comments and close on this PR?

ytimocin · 2025-04-15T17:23:48Z

@ytimocin could you take a look at the PR comments and close on this PR?

I will close this for now and will get back to that if I have time later.

ytimocin requested review from a team as code owners March 3, 2025 23:17

ytimocin had a problem deploying to functional-tests March 3, 2025 23:17 — with GitHub Actions Failure

ytimocin temporarily deployed to publish-bicep March 3, 2025 23:17 — with GitHub Actions Inactive

ytimocin force-pushed the ytimocin/wfls/lr/refactor/v0 branch from 980a18d to 0d19dd3 Compare March 3, 2025 23:57

ytimocin had a problem deploying to functional-tests March 3, 2025 23:57 — with GitHub Actions Failure

ytimocin temporarily deployed to publish-bicep March 3, 2025 23:57 — with GitHub Actions Inactive

lakshmimsft previously approved these changes Mar 4, 2025

View reviewed changes

lakshmimsft reviewed Mar 4, 2025

View reviewed changes

Removing unnecessary env vars from the LR workflow

c446c7a

Signed-off-by: ytimocin <[email protected]>

ytimocin dismissed lakshmimsft’s stale review via c446c7a March 4, 2025 00:56

ytimocin force-pushed the ytimocin/wfls/lr/refactor/v0 branch from 0d19dd3 to c446c7a Compare March 4, 2025 00:56

ytimocin had a problem deploying to functional-tests March 4, 2025 00:56 — with GitHub Actions Failure

ytimocin temporarily deployed to publish-bicep March 4, 2025 00:56 — with GitHub Actions Inactive

kachawla reviewed Mar 4, 2025

View reviewed changes

ytimocin closed this Apr 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Removing unnecessary env vars from the LR workflow #8725

Removing unnecessary env vars from the LR workflow #8725

Uh oh!

ytimocin commented Mar 3, 2025

Uh oh!

github-actions bot commented Mar 3, 2025 •

edited

Loading

Uh oh!

codecov bot commented Mar 4, 2025 •

edited

Loading

Uh oh!

lakshmimsft Mar 4, 2025

Uh oh!

kachawla Mar 4, 2025

Uh oh!

kachawla Mar 4, 2025

Uh oh!

kachawla Mar 4, 2025

Uh oh!

kachawla left a comment

Uh oh!

kachawla left a comment

Uh oh!

kachawla commented Apr 15, 2025

Uh oh!

ytimocin commented Apr 15, 2025

Uh oh!

Uh oh!

Removing unnecessary env vars from the LR workflow #8725

Removing unnecessary env vars from the LR workflow #8725

Uh oh!

Conversation

ytimocin commented Mar 3, 2025

Description

Type of change

Contributor checklist

Uh oh!

github-actions bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests

Uh oh!

codecov bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lakshmimsft Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

kachawla Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

kachawla Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

kachawla Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

kachawla left a comment

Choose a reason for hiding this comment

Uh oh!

kachawla left a comment

Choose a reason for hiding this comment

Uh oh!

kachawla commented Apr 15, 2025

Uh oh!

ytimocin commented Apr 15, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2025 •

edited

Loading

codecov bot commented Mar 4, 2025 •

edited

Loading