Updating rad version command to also show control plane version #9167

ytimocin · 2025-04-11T22:14:07Z

Description

Updating rad version command to also show control plane version:

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).

Fixes: #8953

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
- Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
- Yes
- Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
- Yes
- Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
- Yes
- Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
- Yes
- Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
- Yes
- Not applicable

radius-functional-tests · 2025-04-11T22:19:14Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`baab250`
Unique ID	func2792a8648f
Image tag	pr-func2792a8648f

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func2792a8648f
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func2792a8648f
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func2792a8648f
controller test image location: ghcr.io/radius-project/dev/controller:pr-func2792a8648f
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func2792a8648f
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

github-actions · 2025-04-11T22:26:01Z

Unit Tests

3 726 tests +22 3 724 ✅ +22 6m 43s ⏱️ -1s
297 suites + 1 2 💤 ± 0
1 files ± 0 0 ❌ ± 0

Results for commit ae24b04. ± Comparison against base commit 7373112.

♻️ This comment has been updated with latest results.

codecov · 2025-04-11T22:26:18Z

Codecov Report

Attention: Patch coverage is 92.62295% with 9 lines in your changes missing coverage. Please review.

Project coverage is 55.98%. Comparing base (7373112) to head (ae24b04).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cli/cmd/version/version.go	92.62%	6 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9167      +/-   ##
==========================================
+ Coverage   55.84%   55.98%   +0.13%     
==========================================
  Files         603      604       +1     
  Lines       41344    41466     +122     
==========================================
+ Hits        23090    23216     +126     
+ Misses      16486    16484       -2     
+ Partials     1768     1766       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gpltaylor · 2025-04-13T21:50:29Z

pkg/cli/cmd/version/version.go

+// writeVersionInfo displays both CLI and Control Plane version information
+func (r *Runner) writeVersionInfo(format string) error {
+	// Display CLI version information
+	cliVersion := struct {


lots of dup code here. MIght be best to move this to a builder or helper method to keep thing DRY

brooke-hamilton

I get an error when running rad version when not connected to a radius installation. Maybe just a message saying control plane not connected or something similar.

CLI Version Information:
RELEASE   VERSION                  BICEP     COMMIT
edge      v0.45.0-rc1-11-gbaab250  0.33.93   baab250fd813b4fcdb57717a0f4acec929d1ab7a
Failed to check Radius control plane: Kubernetes cluster unreachable: Get "http://localhost:8080/version": dial tcp 127.0.0.1:8080: connect: connection refused

Control Plane Information:
VERSION        DAPR VERSION
Not installed  Not installed

Also this when running rad version --output json

$ rad version --output json
CLI Version Information:
{
  "release": "edge",
  "version": "v0.45.0-rc1-11-gbaab250",
  "bicep": "0.33.93",
  "commit": "baab250fd813b4fcdb57717a0f4acec929d1ab7a"
}
Failed to check Radius control plane: Kubernetes cluster unreachable: Get "http://localhost:8080/version": dial tcp 127.0.0.1:8080: connect: connection refused

Control Plane Information:
{
  "version": "Not installed",
  "daprVersion": "Not installed"
}

Signed-off-by: ytimocin <[email protected]>

brooke-hamilton

🚀 Looks great:

$ rad version
CLI Version Information:
RELEASE   VERSION             BICEP     COMMIT
edge      v0.46.0-8-gf7b0f3a  0.35.1    f7b0f3a39769393566c450e3c151de5fdb6b53cb

Control Plane Information:
STATUS     VERSION
Installed  0.46.0

$ rad version -o json
{
  "release": "edge",
  "version": "v0.46.0-8-gf7b0f3a",
  "bicep": "0.35.1",
  "commit": "f7b0f3a39769393566c450e3c151de5fdb6b53cb"
}
{
  "version": "0.46.0",
  "status": "Installed"
}

willtsai

minor nitpicks but otherwise looks good to me

pkg/cli/cmd/version/version.go

radius-functional-tests · 2025-05-12T19:40:10Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`c2b221a`
Unique ID	func12bc3a4f1e
Image tag	pr-func12bc3a4f1e

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func12bc3a4f1e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func12bc3a4f1e
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func12bc3a4f1e
controller test image location: ghcr.io/radius-project/dev/controller:pr-func12bc3a4f1e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func12bc3a4f1e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

The base branch was changed.

radius-functional-tests · 2025-05-12T21:17:48Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`5f8f844`
Unique ID	funcad7413e5fe
Image tag	pr-funcad7413e5fe

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcad7413e5fe
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcad7413e5fe
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcad7413e5fe
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcad7413e5fe
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcad7413e5fe
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

brooke-hamilton

🚢

Co-authored-by: Will <[email protected]> Signed-off-by: Yetkin Timocin <[email protected]> Signed-off-by: ytimocin <[email protected]>

radius-functional-tests · 2025-05-12T22:42:14Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`ae24b04`
Unique ID	func663e4d6ca6
Image tag	pr-func663e4d6ca6

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func663e4d6ca6
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func663e4d6ca6
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func663e4d6ca6
controller test image location: ghcr.io/radius-project/dev/controller:pr-func663e4d6ca6
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func663e4d6ca6
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin requested review from a team as code owners April 11, 2025 22:14

ytimocin temporarily deployed to functional-tests April 11, 2025 22:14 — with GitHub Actions Inactive

ytimocin temporarily deployed to publish-bicep April 11, 2025 22:14 — with GitHub Actions Inactive

gpltaylor reviewed Apr 13, 2025

View reviewed changes

brooke-hamilton suggested changes Apr 25, 2025

View reviewed changes

Updating rad version command to also show control plane version

324fb1d

Signed-off-by: ytimocin <[email protected]>

ytimocin force-pushed the ytimocin/update-rad-version branch from baab250 to 324fb1d Compare May 8, 2025 23:07

ytimocin requested a deployment to functional-tests May 8, 2025 23:07 — with GitHub Actions Waiting

ytimocin temporarily deployed to publish-bicep May 8, 2025 23:07 — with GitHub Actions Inactive

Addressing PR feedback

f7b0f3a

Signed-off-by: ytimocin <[email protected]>

ytimocin temporarily deployed to publish-bicep May 8, 2025 23:42 — with GitHub Actions Inactive

ytimocin requested a deployment to functional-tests May 8, 2025 23:42 — with GitHub Actions Waiting

brooke-hamilton previously approved these changes May 9, 2025

View reviewed changes

willtsai reviewed May 12, 2025

View reviewed changes

pkg/cli/cmd/version/version.go Outdated Show resolved Hide resolved

willtsai previously approved these changes May 12, 2025

View reviewed changes

ytimocin temporarily deployed to functional-tests May 12, 2025 19:39 — with GitHub Actions Inactive

ytimocin temporarily deployed to publish-bicep May 12, 2025 19:39 — with GitHub Actions Inactive

ytimocin force-pushed the ytimocin/update-rad-version branch from c2b221a to 5f8f844 Compare May 12, 2025 21:16

ytimocin temporarily deployed to functional-tests May 12, 2025 21:16 — with GitHub Actions Inactive

ytimocin temporarily deployed to publish-bicep May 12, 2025 21:16 — with GitHub Actions Inactive

ytimocin changed the base branch from features/upgrade-v1 to main May 12, 2025 21:16

ytimocin requested review from gpltaylor and willtsai May 12, 2025 21:16

ytimocin requested a review from brooke-hamilton May 12, 2025 21:16

brooke-hamilton approved these changes May 12, 2025

View reviewed changes

Update pkg/cli/cmd/version/version.go

ae24b04

Co-authored-by: Will <[email protected]> Signed-off-by: Yetkin Timocin <[email protected]> Signed-off-by: ytimocin <[email protected]>

ytimocin force-pushed the ytimocin/update-rad-version branch from 5f8f844 to ae24b04 Compare May 12, 2025 22:41

ytimocin temporarily deployed to functional-tests May 12, 2025 22:41 — with GitHub Actions Inactive

ytimocin temporarily deployed to publish-bicep May 12, 2025 22:41 — with GitHub Actions Inactive

willdavsmith approved these changes May 13, 2025

View reviewed changes

ytimocin merged commit 9e5c2fd into main May 13, 2025
33 checks passed

ytimocin deleted the ytimocin/update-rad-version branch May 13, 2025 00:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updating rad version command to also show control plane version #9167

Updating rad version command to also show control plane version #9167

Uh oh!

ytimocin commented Apr 11, 2025 •

edited

Loading

Uh oh!

radius-functional-tests bot commented Apr 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 11, 2025 •

edited

Loading

Uh oh!

codecov bot commented Apr 11, 2025 •

edited

Loading

Uh oh!

gpltaylor Apr 13, 2025

Uh oh!

brooke-hamilton left a comment

Uh oh!

brooke-hamilton left a comment

Uh oh!

willtsai left a comment

Uh oh!

Uh oh!

radius-functional-tests bot commented May 12, 2025 •

edited

Loading

Uh oh!

radius-functional-tests bot commented May 12, 2025 •

edited

Loading

Uh oh!

brooke-hamilton left a comment

Uh oh!

radius-functional-tests bot commented May 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Updating rad version command to also show control plane version #9167

Updating rad version command to also show control plane version #9167

Uh oh!

Conversation

ytimocin commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Contributor checklist

Uh oh!

radius-functional-tests bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

github-actions bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests

Uh oh!

codecov bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gpltaylor Apr 13, 2025

Choose a reason for hiding this comment

Uh oh!

brooke-hamilton left a comment

Choose a reason for hiding this comment

Uh oh!

brooke-hamilton left a comment

Choose a reason for hiding this comment

Uh oh!

willtsai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

radius-functional-tests bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

radius-functional-tests bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

brooke-hamilton left a comment

Choose a reason for hiding this comment

Uh oh!

radius-functional-tests bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Uh oh!

Uh oh!

ytimocin commented Apr 11, 2025 •

edited

Loading

radius-functional-tests bot commented Apr 11, 2025 •

edited

Loading

github-actions bot commented Apr 11, 2025 •

edited

Loading

codecov bot commented Apr 11, 2025 •

edited

Loading

radius-functional-tests bot commented May 12, 2025 •

edited

Loading

radius-functional-tests bot commented May 12, 2025 •

edited

Loading

radius-functional-tests bot commented May 12, 2025 •

edited

Loading