Skip to content

Adding 'rad upgrade kubernetes' command #9168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: features/upgrade-v1
Choose a base branch
from

Conversation

ytimocin
Copy link
Contributor

Description

Adding 'rad upgrade kubernetes' command

Type of change

  • This pull request adds or changes features of Radius and has an approved issue (issue link required).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@ytimocin ytimocin requested review from a team as code owners April 12, 2025 00:48
@ytimocin ytimocin temporarily deployed to functional-tests April 12, 2025 00:48 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Apr 12, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 8603535
Unique ID func74d7278745
Image tag pr-func74d7278745
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func74d7278745
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func74d7278745
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func74d7278745
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func74d7278745
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func74d7278745
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link

github-actions bot commented Apr 12, 2025

Unit Tests

3 704 tests  ±0   3 702 ✅ ±0   6m 30s ⏱️ -12s
  298 suites +2       2 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 12d281e. ± Comparison against base commit 7373112.

♻️ This comment has been updated with latest results.

Copy link
Member

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR intended to implement #8095? I want to test this command, but I am looking for the scenarios that this PR is implementing.

@ytimocin ytimocin force-pushed the ytimocin/upgrade-cmd branch from 8603535 to 12d281e Compare May 8, 2025 23:52
@ytimocin ytimocin temporarily deployed to functional-tests May 8, 2025 23:52 — with GitHub Actions Inactive
@ytimocin ytimocin temporarily deployed to publish-bicep May 8, 2025 23:52 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented May 8, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 12d281e
Unique ID funca7ccedc22e
Image tag pr-funca7ccedc22e
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca7ccedc22e
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca7ccedc22e
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funca7ccedc22e
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funca7ccedc22e
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca7ccedc22e
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 222 lines in your changes missing coverage. Please review.

Project coverage is 55.54%. Comparing base (7373112) to head (12d281e).

Files with missing lines Patch % Lines
pkg/cli/cmd/upgrade/kubernetes/kubernetes.go 0.00% 124 Missing ⚠️
pkg/cli/helm/contourclient.go 0.00% 37 Missing ⚠️
pkg/cli/helm/cluster.go 0.00% 28 Missing and 1 partial ⚠️
pkg/cli/helm/helmclient.go 0.00% 26 Missing ⚠️
pkg/cli/cmd/upgrade/upgrade.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           features/upgrade-v1    #9168      +/-   ##
=======================================================
- Coverage                55.84%   55.54%   -0.31%     
=======================================================
  Files                      603      605       +2     
  Lines                    41344    41557     +213     
=======================================================
- Hits                     23090    23084       -6     
- Misses                   16486    16702     +216     
- Partials                  1768     1771       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants