Add routes recipes #50
Conversation
sk593
force-pushed
the
add-routes-recipes
branch
2 times, most recently
from
14ccfb6 to
c66dfe9
Compare
Signed-off-by: sk593 <[email protected]>
sk593
force-pushed
the
add-routes-recipes
branch
2 times, most recently
from
0b3251e to
465b405
Compare
Signed-off-by: sk593 <[email protected]>
sk593
force-pushed
the
add-routes-recipes
branch
3 times, most recently
from
92aa70e to
de46894
Compare
| # Define common configuration | ||
| setup_config() { | ||
| resource_folders=("Security") | ||
| # Define specific resource types to test instead of entire folders |
There was a problem hiding this comment.
Updating the workflow to allow testing to be added for individual resources instead of a namespace
Compute/routes/recipes/kubernetes/bicep/kubernetes-routes.bicep
Outdated
Show resolved
Hide resolved
sk593
force-pushed
the
add-routes-recipes
branch
2 times, most recently
from
a130182 to
26f04ab
Compare
Signed-off-by: sk593 <[email protected]>
sk593
force-pushed
the
add-routes-recipes
branch
from
26f04ab to
801d78a
Compare
Signed-off-by: sk593 <[email protected]>
| gateway_name = "gateway-${local.resource_id_hash}" | ||
| } | ||
|
|
||
| variable "context" { |
There was a problem hiding this comment.
this doesn't seem right/necessary. context will be populated into tf module
we can set
variable "context" {
description = "This variable contains Radius recipe context."
type = any
}
| } | ||
| } | ||
|
|
||
| resource myContainer 'Radius.Compute/containers@2025-08-01-preview' = { |
There was a problem hiding this comment.
I added this application template as an example of how the routes resource can be deployed. I'm not sure that we'd want this to be a test scenario for the repo since it's more of an integration/E2E test and it'd require the Gateway CRD to be installed on the test cluster (I set up the CRDs and necessary RBAC to deploy this when manually testing to verify that it'd work)
There was a problem hiding this comment.
I'm open to suggestions on if this should be included in this repo's test framework
| } | ||
|
|
||
| # Create Gateway for routing | ||
| resource "kubernetes_manifest" "gateway" { |
There was a problem hiding this comment.
I see you have a Gateway and a listener resource in the recipe, plus a reference to Contour. Which makes sense since there are pointers like Route → Gateway → Contour and listener. This is problematic since most clusters don't use Contour and we also don't know what listener the platform engineer wants/needs.
The way I imagined this is:
• Platform engineer installs a Gateway Controller like NGINX. As part of that, the platform engineer creates the Gateway resource that has the listener and the GatewayClass. NGINX actually creates this as part of the install.
• Then the platform engineer sets the parentRefs as a parameter on the Recipe.
The pros of this approach is we enforce separation of concerns. HTTPRoutes is the application part. Gateway and listener are platform engineering tasks. The con is that in order for a Routes resource to work, the Gateway Controller and the parameter must be set correct.
I recommend we remove the Gateway resource from the Recipe. Do you have other ideas about how this workflow should work between platform engineer and developers?
Signed-off-by: sk593 <[email protected]>
| namespace: context.runtime.kubernetes.namespace | ||
| } | ||
| ] | ||
| hostnames: length(hostnames) > 0 ? hostnames : ['localhost'] |
There was a problem hiding this comment.
Rather than defaulting to localhost, I think this should be not specified if it is not provided. From the docs:
If no hostname is specified, traffic is routed based on HTTPRoute rules and filters (optional).
| backendRefs: [ | ||
| { | ||
| name: '${toLower(last(split(rule.destinationContainer.resourceId, '/')))}-${rule.destinationContainer.containerName}' | ||
| port: 80 |
There was a problem hiding this comment.
This needs reference rule.destinationContainer.containerPortName. We cannot assume a port number.
Signed-off-by: sk593 <[email protected]>
sk593
force-pushed
the
add-routes-recipes
branch
from
c60f4df to
20f2eb0
Compare
|
But it's not required in the recipe. Pls check if we need to update schema to align with recipe. |
|
@zachcasper , @sk593 perhaps this was discussed already but should include gRPC as another route_kind in the yaml and update the recipe for it? |
3 participants
This PR adds Recipes for the Routes resource type. Since Routes need a container for the connection to work, this PR also adds a simple container Recipe