[Avatar] Support cross origin in useImageLoadingStatus #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozgurozalp
requested review from
StephenHaney,
vladmoroz,
lucasmotta,
hadihallak and
chaance
as code owners
|
@chaance can you review? |
|
Nice, hopefully this gets merged soon, I'm having this exact issue as well. Btw @ozgurozalp, I think you have to assign crossOrigin to the image variable before the
|
…nd `crossOrigin` are set beforehand
Yes my friend, you may be right, I fixed that part too. |
|
@StephenHaney @vladmoroz @lucasmotta @hadihallak @chaance is there a chance that this PR can go in next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
crossOriginSupport touseImageLoadingStatusHookThis PR adds
crossOriginsupport to theuseImageLoadingStatushook to handle images hosted on external domains that require specificcrossOriginsettings (anonymousoruse-credentials).By including this option, we ensure broader compatibility with external image sources and resolve potential loading issues.
Note: I haven’t added a test for this as I’m not entirely sure how to approach testing this scenario.