Skip to content

Minor fixes in swe-agent-v2/run.py #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shi-Dong wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Minor fixes in swe-agent-v2/run.py #933

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7eeac5c
fix(swe-agent-v2): default MILES_HOST_IP from MASTER_ADDR; drop dupli…
Apr 7, 2026
bd1f056
style(swe-agent-v2): reformat miles_host_ip default on one line
Apr 7, 2026
9cf103a
refactor(swe-agent-v2): simplify MASTER_ADDR default in miles_host_ip
Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion examples/experimental/swe-agent-v2/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@ class ScriptArgs(U.ExecuteTrainConfig):
agent_model_name: str = os.environ.get("AGENT_MODEL_NAME", "model")
harbor_tasks_dir: str = os.environ.get("HARBOR_TASKS_DIR", "/root/harbor_tasks")
router_external_host: str = os.environ.get("MILES_ROUTER_EXTERNAL_HOST", socket.gethostname()) # public IP
miles_host_ip: str = os.environ.get("MILES_HOST_IP", socket.gethostname()) # cluster/pod IP
# Prefer explicit MILES_HOST_IP; else MASTER_ADDR when set (avoids unresolvable pod hostnames on workers).
miles_host_ip: str = (
os.environ.get("MILES_HOST_IP")
or (os.environ.get("MASTER_ADDR") or "").strip()
or socket.gethostname()
)
Comment on lines +52 to +54
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for determining miles_host_ip can be simplified and made more robust. Currently, it doesn't handle potential whitespace in the MILES_HOST_IP environment variable, and the nested or with strip() for MASTER_ADDR is slightly redundant. Using os.environ.get(key, "").strip() is a cleaner and more idiomatic way to handle missing or whitespace-only environment variables in Python.

Suggested change
miles_host_ip: str = (
os.environ.get("MILES_HOST_IP")
or (os.environ.get("MASTER_ADDR") or "").strip()
or socket.gethostname()
)
miles_host_ip: str = (
os.environ.get("MILES_HOST_IP", "").strip()
or os.environ.get("MASTER_ADDR", "").strip()
or socket.gethostname()
)


# W&B settings
wandb_key: str = os.environ.get("WANDB_KEY", os.environ.get("WANDB_API_KEY", ""))
Expand Down
Loading