-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New component: time span picker #2037
Open
Cosmatevs
wants to merge
54
commits into
radzenhq:master
Choose a base branch
from
Cosmatevs:timespan-picker
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,889
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tency with other components, update demos
…k if input not allowed
* DatePicker: add readonly class only if not disabled
* read input value without using JS * fix Value and ConfirmedValue inconsistency
* use culture while parsing * use consistent culture in tests
…nto timespan-picker
…pressions as theory, add more regions
TimeSpanPicker test: add event-related tests for the panel, simplify some tests related to timespan units
* prevent from changing UnconfirmedValue externally by changing Value, * prevent from raising ValueChanged and Change events if the value haven't actually change
…illed and flat variants
enchev
reviewed
Mar 17, 2025
enchev
reviewed
Mar 17, 2025
* revert changes in Popup component * TimeSpanPicker: reimplement inline/popup handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains:
a new helper component:PopupOrInline
, which makes it much easier to handle displaying a part of the component as a popup or just inline,TimeSpanUnit
used to indicate time unit fields that should be shown in the pickerThings I couldn't do:
To take into consideration:
using thein a similar way. The current solution requires a lot of micromanaging (mostly js calls) to make it work and seems prone to breaking.PopupOrInline
component