Skip to content

[WIP] Use DataAPI.metadata instead of redefining it #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] Use DataAPI.metadata instead of redefining it #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05c464d
Update DimensionalData.jl
asinghvi17 Apr 30, 2024
a10403b
Update Lookups.jl
asinghvi17 Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DimensionalData.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import .Lookups: metadata, set, _set, rebuild, basetypeof,
hasselection, units, SelectorOrInterval, Begin, End
import .Dimensions: dims, refdims, name, lookup, kw2dims, hasdim, label, _astuple

import DataAPI.groupby
import DataAPI: groupby, metadata

export Lookups, Dimensions

Expand Down
1 change: 1 addition & 0 deletions src/Lookups/Lookups.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ using Dates, IntervalSets, Extents
import Adapt, ConstructionBase
import InvertedIndices

import DataAPI: metadata
using InvertedIndices: Not
using Base: tail, OneTo, @propagate_inbounds

Expand Down