Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking #946

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Breaking #946

wants to merge 4 commits into from

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Mar 8, 2025

all finialised breaking changes for the next breaking version

tiemvanderdeure and others added 3 commits March 9, 2025 00:29
)

* DimVector of NamedTuple is a NamedTuple table

* bugfix

* remove show

* fix ambiguity
… for `AbstractDimStack` (#903)

* add combine method

* test groupby and similar

* docs entry
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 82.42280% with 74 lines in your changes missing coverage. Please review.

Project coverage is 82.85%. Comparing base (6b41f13) to head (4b8bd51).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/dimindices.jl 87.50% 17 Missing ⚠️
src/array/indexing.jl 70.27% 11 Missing ⚠️
src/array/broadcast.jl 62.96% 10 Missing ⚠️
src/tables.jl 88.23% 10 Missing ⚠️
src/stack/indexing.jl 22.22% 7 Missing ⚠️
src/groupby.jl 90.00% 6 Missing ⚠️
src/array/array.jl 80.00% 5 Missing ⚠️
src/utils.jl 42.85% 4 Missing ⚠️
src/Dimensions/dimension.jl 0.00% 1 Missing ⚠️
src/Lookups/lookup_arrays.jl 75.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
+ Coverage   80.65%   82.85%   +2.20%     
==========================================
  Files          54       55       +1     
  Lines        5148     5313     +165     
==========================================
+ Hits         4152     4402     +250     
+ Misses        996      911      -85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* add preservedims keyword to DimTable

* add tests

* Apply suggestions from code review

Co-authored-by: Anshul Singhvi <[email protected]>

* tests, and fix DimSlices

* better table docs

* cleanup

* test

* indexing overhaul

* fix similar and broadcast for basicdimarray

* bugfix rebuildsliced

* more indexing cleanup

* cleanup similar and gubfix indexing

* bugfixes

* uncomment

* fix doctests

* just dont doctest unreproducable failures, for now

* combine new Tables integrations

* bugfix and cleanup show

* bugfix and more tests for preservedims and mergedims

---------

Co-authored-by: Anshul Singhvi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants