Refactor packaging install pipeline to shared DESTDIR-based library - #750
Merged
rafatosta merged 20 commits intoJun 25, 2026
Merged
Conversation
rafatosta
deleted the
codex/refactor-packaging-infrastructure-for-consistency
branch
June 27, 2026 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DESTDIR.plugin: dumpandprepare_package.Description
builders/common/common.shprovidinglog,build_wheel,install_wheel,project_version,find_qt_dir,install_dictionaries,validate_installandprepare_package, all operating againstDESTDIRonly.builders/anylinux-appimage/get-dependencies.shto sourcebuilders/common/common.sh, download dictionaries if missing, setDESTDIR/PREFIX, and callprepare_packageinstead of building/installing directly into the host.builders/anylinux-appimage/make-appimage.shto consume the preparedAppDir/usr/bin/zapzapexecutable and remove duplicated installation and dictionary copy logic so it focuses only on quick-sharun/AppImage generation.builders/deb/build.shthat sources the common library, exportsDESTDIRto a package root, runsprepare_package, and then builds a.deb; addbuilders/snap/snapcraft.yamlusingplugin: dumpand anoverride-buildthat sourcesbuilders/common/common.sh, setsDESTDIR=$CRAFT_PART_INSTALLand callsprepare_package; add a smallbuilders/snap/build.shwrapper to runsnapcraft.Testing
sh -nonbuilders/common/common.sh,builders/anylinux-appimage/get-dependencies.sh,builders/anylinux-appimage/make-appimage.sh,builders/deb/build.shandbuilders/snap/build.sh, which returned no syntax errors.project_versionwith. builders/common/common.sh; project_version, which printed the package version successfully.DESTDIR=/tmp/zapzap-package-test ./builders/deb/build.sh, which exercised the pipeline but failed in this environment becausepython -Im build(andinstaller) are not available, and attempts topip installthem failed due to network/proxy restrictions.Codex Task