refactor: make origin private, remove unused template_dir from FullGenerationPlan#100
Merged
Conversation
…lGenerationPlan origin is internal bookkeeping consumed only by execute_generation; no legitimate reason for external inspection or mutation. template_dir was stored in the plan but never read during execution (resolve_template happens before the plan is constructed), so drop it entirely rather than just making it private.
raiderrobert
force-pushed
the
fix/diecut-vzq
branch
from
a5eb3d6 to
7127153
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FullGenerationPlanhad all fields public, butsource_info(noworiginafter #99) andtemplate_dirare only ever used insideexecute_generation. No external caller has any reason to read or modify them.originis made private.template_dirturned out to never be read during execution at all — the template directory is resolved before the plan is built and isn't needed again — so it's removed from the struct entirely rather than just made private.