refactor: extract write_cache_metadata and place_in_cache helpers#24
Merged
Conversation
Break up get_or_clone() by extracting metadata serialization and cache placement into focused helper functions, improving readability and making each step independently testable.
Deploying diecut with
|
| Latest commit: |
5cd5234
|
| Status: | ⚡️ Build in progress... |
Match the idiomatic pattern already used by git_ref in the same signature, replacing &Option<String> with Option<&str>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_cache_metadata()andplace_in_cache()fromget_or_clone()get_or_clone()from ~65 lines to ~30, making the high-level flow immediately clearTest plan