refactor: split generate() into plan and execute phases#64
Merged
Conversation
Factor walk_and_render() into plan_render() + execute_plan(), and generate() into plan_generation() + execute_generation(). This separates what-would-happen from actually-doing-it, enabling dry-run support for the new command in a follow-up PR. No behavior change — all existing tests pass unmodified. Closes #61
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
walk_and_render()intoplan_render()+execute_plan()— renders all files in memory first, then writes to disk as a separate stepgenerate()intoplan_generation()+execute_generation()— alignsnewcommand architecture withupdate's existingthree_way_merge()→apply_merge()patternMotivation
Enables dry-run support for the
newcommand (see #62) by separating what-would-happen from actually-doing-it. This is a prerequisite refactor.Test plan
cargo test— all 33 tests pass (30 existing + 3 new)cargo clippy -- -D warnings— no warningstest_plan_render_matches_walk_and_renderverifies byte-for-byte identical outputtest_plan_render_file_countsverifies correct rendered/copied countstest_plan_render_conditional_excludeverifies conditional file exclusion in plan phaseCloses #61
Blocks #62