refactor: strip non-core features and trim to new + list#69
Merged
Conversation
Remove cookiecutter adapter, migration system, three-way merge/update command, Rhai scripting hooks, and associated tests/fixtures. Simplify ResolvedTemplate to native-only fields. Replace Rhai hooks with a simple shell command runner (post_create). CLI retains new, list, check, and ready commands (check/ready removal is next step). -2,736 lines removed across 32 files.
raiderrobert
changed the title
raiderrobert
changed the title
Clippy with -D warnings fails on this unused function left over from the cookiecutter removal in the prior commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diecut updatecommand)post_create: "git init"in diecut.toml)ResolvedTemplate— removedformat,render_all,context_namespacefieldsThis is Phase 1 (steps a-c) of the trim-and-refactor plan. Remaining steps (remove check/ready commands, examples dir, cleanup unused deps, and Phase 2 subpath refactor) will follow.
What's left after this PR
checkandreadycommands (removal is next)rhai,similar,regex-lite,serde_jsondeps still in Cargo.toml (cleanup is next)examples/directory still exists (removal is next)Stats
cargo clippy -- -D warningsclean (1 dead code warning fortoml_value_to_tera, will be addressed in cleanup step)Test plan
cargo buildpassescargo test— 69 unit + 19 integration tests passcargo clippy -- -D warnings— clean (pending dead code cleanup)diecut new <local-template>still worksdiecut liststill works