test: add comprehensive tests for cache module#7
Merged
Conversation
Cover copy_dir_all (flat, nested, symlink-skipping, empty dir), clear_cache (full clear, URL-filtered, URL normalization, missing dir), list_cached (metadata parsing, skip orphans, skip files, empty/missing), and get_or_clone cache-hit paths (with/without ref, stale entry rejection). Use a static Mutex to serialize tests that mutate the DIECUT_CACHE_DIR env var, preventing flaky parallel execution.
raiderrobert
added a commit
that referenced
this pull request
Feb 12, 2026
test: add comprehensive tests for cache module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copy_dir_all,clear_cache,list_cached, andget_or_clonecache-hit pathsMutexto prevent flaky parallel executiontempfile::TempDirfor isolation and theDIECUT_CACHE_DIRenv var overrideTest plan
cargo fmt --checkpassescargo clippy -- -D warningspassescargo testpasses (59 unit + 20 integration tests)