-
Notifications
You must be signed in to change notification settings - Fork 178
Add capability to discard duplicate jobs with concurrency configuration #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add capability to discard duplicate jobs with concurrency configuration #523
Conversation
Thanks for the review @rosa ❤️, I'll review your comments more thoroughly and make some changes. 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rosa, I've made a few changes and believe to have encountered weird interactions with bulk enqueuing which might be a bug. Let me know if you'd like those changes split out into another PR.
I am really in need of this feature. As its not yet available , could you help me in implementing this ? I have a |
@rajeevriitm if you have a look at the read me you should find concurrency controls are available for you to use. The only difference being that jobs will always be blocked, so you may get several jobs that are awaiting execution. |
@rosa any updates on your review here? |
@rosa Just pinging this. Would love to see this functionality get merged! |
@rosa +1 |
Hey, sorry everyone! I've been crazy busy at work in a bunch of unrelated things, but I'm planning for at least a day of Solid Queue work to catch up with all issues and PRs very soon. Thanks y'all for your patience and sorry for the delay! |
Thanks for the review. Gonna have a look and implement any feedback this week |
…ing dispatch to prevent discarded job creation
It'd be a good idea to update https://github.com/rails/rails/blob/c049370882474acffbc8fd5be458e6ecd1d7d1cb/guides/source/active_job_basics.md?plain=1#L346 when merging this as I've changed |
@rosa, pull request is ready for you review again! Let me know what you think. If you're on-board with these changes, I'll also add a PR to update the RoR edge guide. |
Co-authored-by: Philippe Tring <[email protected]>
Closes #176
Add ability to discard duplicate jobs instead of becoming blocked. When configuring
concurrency_limits
withat_limit: discard
jobs scheduled above the concurrency limit are discarded and not executed.Implementation Details
concurrency_at_limit
andat_limit
option toconcurrency_limits