Removing non-deterministic check from processes_lifecycle_test.rb
#664
+0
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#663 helped me quickly identify another source of flakiness from
processes_lifecycle_test.rb.The combination of logs + GPT 5 is really powerful!
Run: https://github.com/p-schlickmann/solid_queue/actions/runs/18749897031/job/53486391931
Logs: https://github.com/p-schlickmann/solid_queue/actions/runs/18749897031/artifacts/4352196774
This test assumed that the background worker crash would leave both
exit_jobandpause_jobin the:claimedstate. In reality, this state is non-deterministic because the supervisor may detect the worker's death and fail the:claimedjobs before the assertion runs.The test was updated to assert only the final, deterministic
:failedstate instead of relying on the transient:claimedstate.Another option to make it 100% deterministic would be pausing the supervisor before that check somehow, and than resume it right after. But I don't think that's a good idea.
Thoughts?