-
Notifications
You must be signed in to change notification settings - Fork 13
Dynamic user agent #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
narekhovhannisyan
wants to merge
3
commits into
main
Choose a base branch
from
dynamic-user-agent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
e2fd8c3
config: add MCP_USER_AGENT to configuration for Mailtrap MCP
narekhovhannisyan 3bd652a
lib: replace static USER_AGENT with dynamic user agent function in Ma…
narekhovhannisyan 9da5776
lib: implement dynamic User-Agent detection for Mailtrap MCP context
narekhovhannisyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import CONFIG from "../config"; | ||
|
||
const { USER_AGENT, MCP_USER_AGENT } = CONFIG.CLIENT_SETTINGS; | ||
|
||
/** | ||
* Checks if the main module filename indicates MCP context. | ||
* @returns true if main module contains "mailtrap-mcp" and is not in node_modules | ||
*/ | ||
function isMainModuleMCP(): boolean { | ||
const mainFile = require?.main?.filename; | ||
|
||
return !!( | ||
mainFile && | ||
mainFile.includes("mailtrap-mcp") && | ||
!mainFile.includes("node_modules") | ||
); | ||
} | ||
|
||
/** | ||
* Checks if the current working directory indicates MCP context. | ||
* @returns true if cwd contains "mailtrap-mcp" and is not in node_modules | ||
*/ | ||
function isWorkingDirectoryMCP(): boolean { | ||
try { | ||
const cwd = process.cwd(); | ||
return cwd.includes("mailtrap-mcp") && !cwd.includes("node_modules"); | ||
} catch { | ||
return false; | ||
} | ||
} | ||
|
||
/** | ||
* Checks if the call stack indicates MCP context. | ||
* @returns true if stack contains "mailtrap-mcp" and is not from node_modules/mailtrap | ||
*/ | ||
function isCallStackMCP(): boolean { | ||
const { stack } = new Error(); | ||
|
||
return !!( | ||
stack && | ||
stack.includes("mailtrap-mcp") && | ||
!stack.includes("node_modules/mailtrap") | ||
); | ||
} | ||
|
||
/** | ||
* Determines if the code is running in a Mailtrap MCP context. | ||
* Uses multiple detection methods to ensure accurate context identification. | ||
* @returns true if running in MCP context, false otherwise | ||
*/ | ||
function isMailtrapMCPContext(): boolean { | ||
return isMainModuleMCP() || isWorkingDirectoryMCP() || isCallStackMCP(); | ||
} | ||
|
||
/** | ||
* Gets the appropriate User-Agent string based on the current context. | ||
* @returns The User-Agent string for the current context | ||
*/ | ||
function getDynamicUserAgent(): string { | ||
return isMailtrapMCPContext() ? MCP_USER_AGENT : USER_AGENT; | ||
} | ||
|
||
export default getDynamicUserAgent; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix ESM ReferenceError risk from using
require
directly.require?.main
still throws in pure ESM becauserequire
is an unbound identifier. Guard withtypeof require !== 'undefined'
and fall back toprocess.argv[1]
.Apply this diff:
🤖 Prompt for AI Agents