Skip to content

feat: add compatibility with Postgres 17 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PaiJi
Copy link

@PaiJi PaiJi commented Dec 13, 2024

No description provided.

@PaiJi PaiJi changed the title feat: Fix compatibility with Postgres 17 feat: add compatibility with Postgres 17 Dec 13, 2024
@brody192
Copy link
Contributor

brody192 commented Dec 18, 2024

We still deploy PG 16 by default, so I'm going to have to hold off on merging this for now as I do not know what adverse effects running pg_backup 17 on a PG 16 database could introduce, but thank you for the PR!

^ Though If you have any data on running pg_dump 17 with PG 16, I'd love to see it.

@pepijn-vanvlaanderen
Copy link
Contributor

Dumping should be no problem with v17 for a v16 database. Only restoring a v17 dump into a v16 database could create issues.

Best would be to make the PG_VERSION adjustable maybe.

@brody192
Copy link
Contributor

brody192 commented Jan 17, 2025

It is - https://github.com/railwayapp-templates/postgres-s3-backups/blob/main/Dockerfile#L23

If you set PG_VERSION yourself via a service variable, what you set will be used in place.

@pepijn-vanvlaanderen
Copy link
Contributor

pepijn-vanvlaanderen commented Jan 17, 2025

Ah I see, that is great. But v17 is not available on node 20, this PR is needed for that to work I guess.

Edit: I've opened a PR that is backwards compatible and allows users to configure the template for v17 as well: #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants