Fixed validation logic and download behavior #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for resume-generator011 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @rajdeep13-coder just following up on this PR. Let me know if any changes are needed before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the resume couldn’t be downloaded unless all form fields were filled correctly.
This was a problem because:
Some users may want to preview the resume before completing the form.
Incomplete but partially filled forms still blocked download, which was frustrating.
What I Did
I modified the validation function to show an alert when errors are present.
The alert asks the user if they still want to continue.
If the user clicks "OK", the resume is downloaded anyway.
If they click "Cancel", the download is stopped.
Why It’s Correct
The original strict validation blocked all users with even small errors.
My change gives flexibility while still alerting users about mistakes.
It keeps the resume preview feature functional without forcing full form completion.
I tested both complete and incomplete forms — the resume downloads properly in both cases.