Skip to content

Removed unused imports and variables - #704

Open
thomasvaeth wants to merge 3 commits into
rajnandan1:mainfrom
thomasvaeth:main
Open

Removed unused imports and variables#704
thomasvaeth wants to merge 3 commits into
rajnandan1:mainfrom
thomasvaeth:main

Conversation

@thomasvaeth

Copy link
Copy Markdown

Summary

  • Enabled noUnusedLocals in tsconfig.json and removed all unused imports and variables
    • Opted for noUnusedLocals over adding ESLint to keep the toolchain light
    • I did not enable noUnusedParameters, but there were another 28 errors there if following up
  • Fixed optional chaining consistency for children snippet
  • Ran Prettier across the codebase

Test plan

  • Run npm run check to confirm no TypeScript errors
  • Smoke test the status page, admin dashboard, and embed routes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant