-
-
Notifications
You must be signed in to change notification settings - Fork 288
feat: custom metric units display and formatting #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
123FLO321
wants to merge
35
commits into
rajnandan1:main
Choose a base branch
from
123FLO321:feature/custom-metric-units
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
060d8d9
chore: enforce LF line endings via .gitattributes, ignore .idea and .…
123FLO321 fca7624
test: add Vitest server project with tool.ts timestamp tests
123FLO321 180c963
test: cover tool.ts uptime math (ParseUptime, formulas, UptimeCalcula…
123FLO321 048518f
test: cover tool.ts validation and string helpers
123FLO321 e800867
test: add Vitest browser-mode client project with CopyButton test
123FLO321 2dc46ab
test: add StatusBarCalendar browser-mode component test
123FLO321 ae1586c
test: pin test timezone to UTC, document test commands
123FLO321 a7b5c2c
ci: add test workflow with Playwright browser caching
123FLO321 c40b41a
ci: disable credential persistence, read Playwright version from inst…
123FLO321 3fc1d75
test: use extends: true for Vitest projects, guard clipboard spy target
123FLO321 4366705
feat: add FormatValue formatter with per-monitor value display config
123FLO321 6d80939
feat: thread value display config through server-side formatting
123FLO321 f4af55d
fix: gate day-latency no-data as empty, format last-latency with valu…
123FLO321 9c39b95
fix: last-latency shows blank for missing readings on custom-unit mon…
123FLO321 4738e3b
feat: interpolate i18n fallback keys, add value-display label keys
123FLO321 b160cec
feat: render custom metric units on status page components
123FLO321 3f2ad36
feat: custom metric units in embed widgets
123FLO321 43f0a7d
feat: metric display settings card and unit-aware admin tables
123FLO321 e5ca8bf
fix: sync sibling admin cards after metric display save
123FLO321 8166769
docs: document per-monitor metric display settings
123FLO321 36e81fb
style: fix prettier formatting on admin UI metric display files
123FLO321 1552d5b
fix: final review fixes — decimals null handling, % join, DayHasData …
123FLO321 699c6a2
fix: swap remaining latency labels for custom display names
123FLO321 4fa0754
fix: custom display names in badges, embed, and group settings labels
123FLO321 4713299
docs: update todo about next major
123FLO321 78b903c
refactor: rename MonitorBarResponse.value_display to valueDisplay
123FLO321 87bd9e9
fix: exclude all-NULL reading days from custom-unit aggregates
123FLO321 01a428c
chore: restrict permissions for test workflow
123FLO321 dda87e6
Merge branch 'feat/test-setup' into feature/custom-metric-units
123FLO321 857283e
refactor: consolidate value-display label derivations, add docstrings
123FLO321 935617c
docs: correct FormatValue and MonitorValueDisplay docstrings
123FLO321 9e479cd
refactor: simplify lastStatus accessors with optional chaining
123FLO321 76fcf1c
docs: add docstrings to metric display admin functions
123FLO321 575d7f7
docs: expand DayHasReading and monitor-bar helper docstrings
123FLO321 2292df1
style: fix indents
123FLO321 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * text=auto eol=lf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| name: Tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4.2.2 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
| cache: npm | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Get Playwright version | ||
| id: playwright-version | ||
| run: echo "version=$(npx playwright --version | awk '{print $2}')" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Cache Playwright browsers | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ~/.cache/ms-playwright | ||
| key: playwright-${{ runner.os }}-${{ steps.playwright-version.outputs.version }} | ||
|
|
||
| - name: Install Playwright Chromium | ||
| run: npx playwright install --with-deps chromium | ||
|
|
||
| - name: Type check | ||
| run: npm run check | ||
|
|
||
| - name: Run tests | ||
| run: npm test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.