Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #2238

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Update setup.py #2238

wants to merge 3 commits into from

Conversation

R5dan
Copy link
Contributor

@R5dan R5dan commented Jan 23, 2025

  • Fixes setup.py
  • Adds new install command to properly print message
  • Prints any warnings for specific versions (would have been useful for the last version with Screener being redone) - trying to stop issues when in docs for big overhauls.

This is a draft as there is very little documentation for the actual install command, so it needs fixing. Any help welcome.

@dhruvan2006
Copy link
Contributor

  • Fixes setup.py

What was broken?

@R5dan R5dan changed the base branch from main to dev January 24, 2025 10:44
@R5dan R5dan changed the title Update status.py Update setup.py Jan 24, 2025
@R5dan
Copy link
Contributor Author

R5dan commented Jan 24, 2025

What was broken?

The message/disclaimer never printed
I also changed it to install pandas[html] instead of pandas+ everything needed for pandas[html]
The classifiers also only went up to 3.10

setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@ValueRaider
Copy link
Collaborator

This is a draft as there is very little documentation for the actual install command, so it needs fixing.

What are you trying to do (with Install)?

@R5dan
Copy link
Contributor Author

R5dan commented Jan 25, 2025

What are you trying to do (with Install)?

Currently, I believe that it simply uses the default install command, as it (1) doesn't print to the terminal and (2) I have tried getting it to write to a file and it doesn't do it.

The only documentation is for the Command class (which Install is a subclass of) but I want to use install so it actually installs properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants