Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Marketplace Support - fix branding, support config download button #6196

Conversation

mantis-toboggan-md
Copy link
Member

Fixes #4916 (comment)
Between when I did this work and when the backend side was finalized, a couple things changed that broke the UI side.

  1. The name of the csp-adapter app changed (csp-adapter->rancher-csp-adapter)
  2. The way the support config download endpoint is constructed changed (the csp-adapter svc no longer exists)

Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing before we merge.. I don't see anything in this PR that warrants the change to yarn.lock. Can we remove it from this PR and raise a new one if the lock file needs an update?

@mantis-toboggan-md mantis-toboggan-md force-pushed the aws-marketplace-support-config branch from c4d8137 to d04afe4 Compare June 17, 2022 21:39
@mantis-toboggan-md mantis-toboggan-md force-pushed the aws-marketplace-support-config branch from d04afe4 to e4e1326 Compare June 17, 2022 21:43
@mantis-toboggan-md mantis-toboggan-md merged commit c8b6946 into rancher:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Marketplace Integration - Support Config
2 participants