-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New CI Lane for Upgrade rancher #251
Conversation
6fde8cc
to
306b873
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me, but first please make the CI green.
59c5727
to
57e7e7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seeems ok, thanks a lot.
I have a couple of comments. Pls review them before approval.
FYI: some of the errors on 2.9 should be ok after merge of: #258 |
I will wait till this PR merged. |
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
bd0fcd6
to
a83a8fb
Compare
I have resolve all the comments after addressing those. Thanks for the comments/review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion added, other than that it looks good to me.
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Fixes: #261
CI Run Job: https://github.com/rancher/fleet-e2e/actions/runs/12952326077
Image that shows all required information: