Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CI Lane for Upgrade rancher #251

Merged
merged 11 commits into from
Jan 29, 2025
Merged

New CI Lane for Upgrade rancher #251

merged 11 commits into from
Jan 29, 2025

Conversation

sbulage
Copy link
Collaborator

@sbulage sbulage commented Jan 10, 2025

Fixes: #261
CI Run Job: https://github.com/rancher/fleet-e2e/actions/runs/12952326077

Image that shows all required information:

image

@sbulage sbulage added the fleet-e2e-ci Improvements or additions to the CI framework label Jan 10, 2025
@sbulage sbulage requested a review from thehejik January 10, 2025 16:12
@sbulage sbulage force-pushed the upgrade_rancher branch 3 times, most recently from 6fde8cc to 306b873 Compare January 11, 2025 09:24
Copy link
Collaborator

@thehejik thehejik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me, but first please make the CI green.

@sbulage sbulage force-pushed the upgrade_rancher branch 23 times, most recently from 59c5727 to 57e7e7e Compare January 23, 2025 11:27
@sbulage sbulage requested review from mmartin24 and thehejik January 24, 2025 16:16
Copy link
Collaborator

@mmartin24 mmartin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seeems ok, thanks a lot.
I have a couple of comments. Pls review them before approval.

@mmartin24
Copy link
Collaborator

FYI: some of the errors on 2.9 should be ok after merge of: #258

@sbulage
Copy link
Collaborator Author

sbulage commented Jan 28, 2025

FYI: some of the errors on 2.9 should be ok after merge of: #258

I will wait till this PR merged.

Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
@sbulage
Copy link
Collaborator Author

sbulage commented Jan 28, 2025

I have resolve all the comments after addressing those. Thanks for the comments/review 😄

Copy link
Collaborator

@mmartin24 mmartin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
@sbulage
Copy link
Collaborator Author

sbulage commented Jan 28, 2025

Latest CI Run: https://github.com/rancher/fleet-e2e/actions/runs/13015515399

Upgrade CI: 2.10 to Head version

image

Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
@sbulage sbulage requested a review from weyfonk January 28, 2025 17:31
Copy link
Collaborator

@thehejik thehejik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion added, other than that it looks good to me.

Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
@sbulage sbulage merged commit e0338cb into main Jan 29, 2025
6 checks passed
@sbulage sbulage deleted the upgrade_rancher branch January 29, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fleet-e2e-ci Improvements or additions to the CI framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New CI lane for Rancher Upgrade
4 participants