Add extra_args_array Field

[khrisrichardson]

Issue:

#1209

Problem

Two new fields were added to RKE, ExtraArgsArray and WindowsExtraArgsArray. These fields allow users to specify an extraArg multiple times with different values. The provider now needs to be updated to support these two new fields.

Solution

An extra_args_array set field was added adjacent to the existing extra_args field.

Testing

Engineering Testing

Manual Testing

Here's a snippet demonstrating which fields were added, with everything else in ellipsis.

resource "rancher2_cluster" "cluster" {

  rke_config {
    services {
      kube_api {
        extra_args_array {
          name  = "api-audiences"
          value = [
            "sts.amazonaws.com",
          ]
        }
        extra_args_array {
          name  = "service-account-key-file"
          value = [
            "/etc/kubernetes/ssl/sa-signer-pkcs8.pub",
          ]
        }
        extra_args_array {
          name  = "service-account-issuer"
          value = [
            "rke",
          ]
        }
      }
   }
}

And these were the results, trimmed for clarity

      ~ rke_config {
          ~ services {
              ~ kube_api {
                  + extra_args_array {
                      + name  = "api-audiences"
                      + value = [
                          + "sts.amazonaws.com",
                        ]
                    }
                  + extra_args_array {
                      + name  = "service-account-issuer"
                      + value = [
                          + "rke",
                        ]
                    }
                  + extra_args_array {
                      + name  = "service-account-key-file"
                      + value = [
                          + "/etc/kubernetes/ssl/sa-signer-pkcs8.pub",
                        ]
                    }
                }
            }
        }
    }

Automated Testing

Tests have been added only to rancher2/structure_cluster_rke_config_services_etcd_test.go, since the tests for the other services would otherwise use identical schemas, flatteners, and expanders.

QA Testing Considerations

Regressions Considerations

[krichardson-tubi]

CC: @a-blender, could you recommend a reviewer for this PR please? My apologies for keeping it in draft for so long.

[khrisrichardson]

CC: @snasovich, would you by any chance be able to assign a reviewer? Thanks

[richardcase]

Thanks @khrisrichardson .

Is it ok to specify both extra_args and the new extra_args_array?

[khrisrichardson]

Is it ok to specify both extra_args and the new extra_args_array?

@richardcase that is correct, just as they are not mutually exclusive in the rancher/rancher or rancher/rke code

[krichardson-tubi]

@richardcase do you have any additional concerns or questions?

[nobbs]

Any chance to get this PR reopened and merged? We're facing an issue as we need to update the service-account-issuer argument for the kube apiserver of a rke-based cluster without breaking every service account token based authentication. Kube-Apiserver does support specifying this argument multiple times, but without support in the terraform provider, we can't make use of it.

[khrisrichardson]

@nobbs you made the right move opening a new PR. Godspeed