Add ExternalRules to RoleTemplate #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulcabello
changed the title
matttrach
reviewed
Jun 18, 2024
|
hi @raulcabello, a PR for adding GHA workflows was just merged, could you rebase your PR against the base branch so that the workflow will run on your PR? |
raulcabello
force-pushed
the
external-rules-v3
branch
from
cdec3f1 to
7a790fe
Compare
I bumped the Rancher version because we need the new |
JonCrowther
approved these changes
Jun 19, 2024
pmatseykanets
approved these changes
Jun 20, 2024
External rules used for authorization. This field is required when External=true and no underlying ClusterRole exists --------- Co-authored-by: Jonathan Crowther <[email protected]> Co-authored-by: Enrico Candino <[email protected]> bump rancher version to include external rules Signed-off-by: raul <[email protected]>
raulcabello
force-pushed
the
external-rules-v3
branch
from
7a790fe to
c2a5da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #1356
Co-authored-by: Jonathan Crowther [email protected]
Co-authored-by: Enrico Candino [email protected]