Add pull request workflow #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snasovich
reviewed
Jun 18, 2024
There was a problem hiding this comment.
LGTM at a glance but some observations/questions:
- On Drone we ran
make docker-buildandmake build-rancheris basically equivalent of it minus Docker. Why do we need to runmake package-rancher? - Any specific reason we're running on
ubuntu-20.04vs.ubuntu-latest?
HarrisonWAffel
force-pushed
the
pull-request-workflow
branch
from
55c8c93 to
f0da508
Compare
|
I've updated to |
HarrisonWAffel
force-pushed
the
pull-request-workflow
branch
from
f0da508 to
d04a3bd
Compare
snasovich
reviewed
Jun 18, 2024
HarrisonWAffel
force-pushed
the
pull-request-workflow
branch
3 times, most recently
from
29d66ab to
866fbbe
Compare
HarrisonWAffel
force-pushed
the
pull-request-workflow
branch
from
866fbbe to
6efbc74
Compare
jiaqiluo
pushed a commit
to jiaqiluo/terraform-provider-rancher2
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#1351 missed a workflow for pull requests, as such we are not building and packaging the provider before allowing PRs to be merged
Solution
Add a pull request workflow which builds and packages the provider for each PR. This PR does not include the acceptance tests, as additional effort needs to be put into how we can modernize those tests such that they can work against a more modern version of rancher.
Testing
I've tested this workflow on my personal fork
Actions run: https://github.com/HarrisonWAffel/terraform-provider-rancher2/actions/runs/9571691853/job/26389359180