✨ Enable CAPI UI extension installation #1083
Open
+280
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
changed the title
Danil-Grigorev
force-pushed
the
auto-install-ui
branch
2 times, most recently
from
c752c12 to
28ead87
Compare
Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
auto-install-ui
branch
from
28ead87 to
d463f94
Compare
anmazzotti
previously approved these changes
Feb 17, 2025
yiannistri
previously approved these changes
Feb 18, 2025
Co-authored-by: Yiannis Triantafyllopoulos <[email protected]>
Danil-Grigorev
dismissed stale reviews from yiannistri and anmazzotti
via
eaf8ab2
anmazzotti
approved these changes
Feb 18, 2025
alexander-demicev
approved these changes
Feb 18, 2025
| // SetupWithManager sets up the controller with the Manager. | ||
| func (r *UIPluginReconciler) SetupWithManager(_ context.Context, mgr ctrl.Manager, _ controller.Options) error { | ||
| uiPlugin := &metav1.PartialObjectMetadata{} | ||
| uiPlugin.SetGroupVersionKind(schema.GroupVersionKind{ |
There was a problem hiding this comment.
should this be a part of the rancher API wrapper?
| - variable: capi.enabled | ||
| default: true | ||
| type: boolean | ||
| description: "Flag to enable or disable installation of CAPI UI extension. If set to false then you will need to install CAPI UI extension manually." |
There was a problem hiding this comment.
is it possible to add to the description that UI is still experimental? can be done in a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #1082