Skip to content

Conversation

Copy link

Copilot AI commented Nov 28, 2025

Issue:

Port of rancher/turtles@7884d64

Problem

When releasing a new webhook minor version (e.g., v0.5.0 → v0.6.0-rc.0), the chart major version needs to be bumped (e.g., 104.0.0 → 105.0.0). The existing release scripts only support patch version bumps.

Solution

Added bump_major parameter to release workflows and scripts:

  • .github/workflows/release-charts.yaml / release-rancher.yaml: Added bump_major workflow input (choice: true/false)
  • .github/workflows/scripts/release-against-charts.sh / release-against-rancher.sh:
    • Added bump_major() function (increments major, resets minor/patch to 0)
    • Added minor version detection logic using cut -d. -f2 for simplified extraction
    • bump_major is now a required argument (must be "true" or "false")
    • Script errors if minor version increases without bump_major=true
    • Informative commit messages indicating bump type

Usage examples from updated script help:

RC to RC:        ./release-against-charts.sh ./charts v0.5.0-rc.0 v0.5.0-rc.1 false
RC to stable:    ./release-against-charts.sh ./charts v0.5.0-rc.0 v0.5.0 false
stable to RC:    ./release-against-charts.sh ./charts v0.5.0 v0.5.1-rc.1 false
new minor RC:    ./release-against-charts.sh ./charts v0.5.0 v0.6.0-rc.0 true   # bump chart major

CheckList

  • Test - Shell syntax validated; YAML syntax validated; no functional tests needed (workflow dispatch scripts)
  • Docs - Usage examples added to script headers
Original prompt

Bring the changes from rancher/turtles@7884d64 to our repository.

Both repositories have the same GHA defined, but the turtles one include a fix.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Bring changes from turtles repository fix Add bump_major support for chart version bumps when webhook minor version increases Nov 28, 2025
Copilot AI requested a review from tomleb November 28, 2025 17:36
Copilot finished work on behalf of tomleb November 28, 2025 17:36
Copilot AI requested a review from tomleb November 28, 2025 17:57
Copilot finished work on behalf of tomleb November 28, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants