Merged
Conversation
- Add default = ["mcp"] to Cargo.toml so MCP works out of the box - Add test-no-default-features CI job to verify sync-only build - Update docs: README, architecture, CLAUDE.md reflect MCP as default - Update src/mcp/mod.rs doc comment to say 'default feature' - Library users can opt out with default-features = false Closes #76
- Replace Runtime::new() with Builder::new_current_thread() for MCP stdio - Remove rt-multi-thread from tokio features (not needed for sequential stdio) - Expand From<Error> for rmcp::ErrorData to handle InvalidInput, Validation, InvalidTimestamp, and NotFound variants with appropriate error codes - Only truly internal/unrecoverable errors now use INTERNAL_ERROR
randomm
force-pushed
the
feature/issue-76-mcp-default-feature
branch
from
19c0460 to
7ed69db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes MCP server a default feature so
vipune mcpworks without--features mcp.Changes
default = ["mcp"]to[features]sectiontest-no-default-featuresjob to verify sync-only builds still work--features mcp, notedefault-features = falseescape hatchDesign Decision
The
#[cfg(feature = "mcp")]gates remain in code — they protect sync-only downstream library users. MCP is simply ON by default now. Library users can opt out withdefault-features = falsein their Cargo.toml.Quality Gates
cargo fmt --check✅cargo clippy -- -D warnings✅cargo test✅ (161 passed)cargo test --no-default-features✅ (154 passed)cargo clippy --no-default-features -- -D warnings✅Fixes #76